850875 - Regressed Setting environment variable for Fennec

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Benoit Girard (:BenWa)]

As of about March 10 it appears that we can no longer set environment variables in Fennec using this syntax:
adb shell am start -n org.mozilla.fennec_$USER/.App --es env0 MOZ_PROFILER_STARTUP=1

This should be handled from loadMozGlue but it fails because !(context instanceof Activity) is true. Context is of type 'org.mozilla.gecko.GeckoApplication' and it's being invoked from here:
W/System.err(15847): java.lang.RuntimeException: 
W/System.err(15847): 	at org.mozilla.gecko.mozglue.GeckoLoader.loadMozGlue(GeckoLoader.java:239)
W/System.err(15847): 	at org.mozilla.gecko.GeckoApplication.onCreate(GeckoApplication.java:69)
W/System.err(15847): 	at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:999)
W/System.err(15847): 	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:4151)
W/System.err(15847): 	at android.app.ActivityThread.access$1300(ActivityThread.java:130)
W/System.err(15847): 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1255)
W/System.err(15847): 	at android.os.Handler.dispatchMessage(Handler.java:99)
W/System.err(15847): 	at android.os.Looper.loop(Looper.java:137)
W/System.err(15847): 	at android.app.ActivityThread.main(ActivityThread.java:4745)
W/System.err(15847): 	at java.lang.reflect.Method.invokeNative(Native Method)
W/System.err(15847): 	at java.lang.reflect.Method.invoke(Method.java:511)
W/System.err(15847): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
W/System.err(15847): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
W/System.err(15847): 	at dalvik.system.NativeStart.main(Native Method)

Comment 1

[William Lachance (:wlach)]

This worked on the March 9th nightly, so the regression must have occurred sometime after that was built.

Comment 2

[William Lachance (:wlach)]

By the way, this breaks profiling for fennec.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Yay for unintended consequences.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Try build in progress at https://tbpl.mozilla.org/?tree=Try&rev=612b84067f06. Once that's done, BenWa, can you verify that build doesn't suffer from the same problem?

Comment 5

[William Lachance (:wlach)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #4)

> Try build in progress at
> https://tbpl.mozilla.org/?tree=Try&rev=612b84067f06. Once that's done,
> BenWa, can you verify that build doesn't suffer from the same problem?

Just verified that the try build fixed the issue. FWIW, here's the reproduction steps for the bug:

adb shell am start -W -n org.mozilla.fennec/.App -a android.intent.action.VIEW --es env0 MOZ_PROFILER_STARTUP=true -d https://google.com

Expected: 

Should see the following types of entries in the logcat:

E/Profiler(  842): Registering start signal
E/Profiler(  842): Sampler started
E/Profiler(  842): Request signal
E/Profiler(  842): Signal installed
E/Profiler(  842): Profiler thread started

Comment 6

[Benoit Girard (:BenWa)]

Comment on attachment 724734 [details] [diff] [review]
Patch

Review of attachment 724734 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the quick fix

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 724734 [details] [diff] [review]
Patch

Switching reviewer since cpeterson is on PTO

Comment 8

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/acc201607999

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/acc201607999