850929 - GCLI needs a simpler way to mark parameters as being options

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

var tempSpec = {
    name: 'temp',
    params: [
      {
        name: 'text',
        type: 'string',
        option: true
      }
    ],
    exec: ...
  };


Is better than

  var tempSpec = {
    name: 'temp',
    params: [
      {
        group: 'Options',
        params: [
          {
            name: 'text',
            type: 'string',
          }
        ]
      }
    ],
    exec: ...
  };

option:true gets you the default group name of "Option", or you can specify a custom name with option:"Advanced"

Comment 1

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

Attachment: v1

Comment 2

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

The meat of attachment 726541 [details] [diff] [review] in context: https://github.com/joewalker/gcli/blob/91e78eb0886a3753aba5998ab74558c24176ceb1/lib/gcli/canon.js#L118

Comment 3

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

https://tbpl.mozilla.org/?tree=Try&rev=3e7f38b6ccfc

Comment 4

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=f952eebd4cbd
https://hg.mozilla.org/integration/fx-team/rev/55bea9d170b7

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/55bea9d170b7