850936 - [Tablet] - Unable to change tab sections after rotation with sidebar open

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently when one performs a rotation from portrait (with the tab menu open) and over to landscape (with the sidebar open), one is unable to change the selected tab sections.

Steps to reproduce (using my Nexus 7, Android 4.2.2)

i) Open the tab menu in portrait (regular tabs)
ii) Rotate to landscape (tap the private tab section)

Tapping the remote or private tab section does nothing.

Haven't tested mozilla-aurora or mozilla-beta.

http://i.imgur.com/ldAL5.gif

Comment 1

[Aaron Train [:aaronmt]]

08:23 sriram:	 that's lucas's

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Actually update toolbar layout state on rotation

Calling adjustTabsAnimation() with 'false' was only update translation of the toolbar's inner children so the toolbar view was still 'covering' the tabs tray. Calling adjustTabsAnimation() with 'true' does the right thing.

Comment 3

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/a5447c2831e7

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a5447c2831e7