Closed Bug 850957 Opened 7 years ago Closed 7 years ago

Update injection test for some functions

Categories

(Toolkit :: General, defect)

x86
Windows 8
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

toolkit/crashreporter/nsExceptionHandler.cpp and xpcom/base/AvailableMemoryTracker.cpp injects some functions, but this isn't in TestDllInterceptor.cpp.

Also, NtFlushBuffersFile is no longer injected.  We should remove test for it.
Attached patch fixSplinter Review
Attachment #724722 - Flags: review?(ehsan)
Comment on attachment 724722 [details] [diff] [review]
fix

Review of attachment 724722 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the comment below addressed.

::: toolkit/xre/test/win/TestDllInterceptor.cpp
@@ -115,5 @@
>        TestHook("user32.dll", "SetWindowLongA") &&
>        TestHook("user32.dll", "SetWindowLongW") &&
>  #endif
>        TestHook("user32.dll", "TrackPopupMenu") &&
> -      TestHook("ntdll.dll", "NtFlushBuffersFile") &&

This is testing this code <http://hg.mozilla.org/mozilla-central/rev/afbe1011ae1c#l1.12> so I'd rather us keep this test.
Attachment #724722 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/c5e8cbefa8c8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.