851007 - Error: String 'Yes' could not be retrieved from the bundle due to an unknown error (it doesn't exist?).

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This might be the cause of the m-c oranges we're seeing. (Maybe?) It didn't exist on the older green runs from a few days ago, but show up in recent tests. I don't see a failing test, but it does throw a traceback with an error.

Still don't have a clue what caused the change, though...


TEST-PASS | tests/test-app-strings.testStringBundle | 'url' property contains correct URL of string bundle
An exception occurred.
Traceback (most recent call last):
  File "resource://extensions.modules.972a117b-a6e6-45ed-a0f4-7c9b2c773b43-at-jetpack.commonjs.path/sdk/timers.js", line 31, in notify
    callback.apply(null, args);
  File "resource://extensions.modules.972a117b-a6e6-45ed-a0f4-7c9b2c773b43-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 286, in 
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://extensions.modules.972a117b-a6e6-45ed-a0f4-7c9b2c773b43-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 456, in 
    options.onDone(self);
  File "resource://extensions.modules.972a117b-a6e6-45ed-a0f4-7c9b2c773b43-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 438, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://extensions.modules.972a117b-a6e6-45ed-a0f4-7c9b2c773b43-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 469, in start
    this.test.testFunction(this);
  File "resource://extensions.modules.972a117b-a6e6-45ed-a0f4-7c9b2c773b43-at-jetpack.commonjs.path.tests/test-app-strings.js", line 25, in exports.testStringBundle
    test.assertEqual(strings.get(name), stringBundle.GetStringFromName(name),
  File "resource://extensions.modules.972a117b-a6e6-45ed-a0f4-7c9b2c773b43-at-jetpack.commonjs.path/sdk/deprecated/app-strings.js", line 49, in strings_get
    "bundle due to an unknown error (it doesn't exist?).");
Error: String 'Yes' could not be retrieved from the bundle due to an unknown error (it doesn't exist?).

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'd guess this is the test: https://github.com/mozilla/addon-sdk/blob/master/test/test-app-strings.js#L24-27

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

And I'd guess http://hg.mozilla.org/mozilla-central/rev/ea9b4ef5df58 broke it.

Comment 3

[:Cykesiopka]

Sigh, guess my searching skills have been lacking then... Thought nothing else used "Yes" in the CAPS stringbundle...

Comment 4

[:Cykesiopka]

Sorry for the screwup by the way... Should I get my changes backed out?
Still trying to see what I missed that caused this...

Comment 5

[Dave Townsend [:mossop]]

(In reply to Cykesiopka from comment #4)
> Sorry for the screwup by the way... Should I get my changes backed out?
> Still trying to see what I missed that caused this...

No, the issue is that the addon-sdk tree is maintained in github so we have to uplift the changes you made to there to fix our tests. I'll do that now.

Comment 6

[:Cykesiopka]

Ah, I see...