Closed Bug 851011 Opened 7 years ago Closed 7 years ago

Remove unused feed handlers from mobile/

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 22

People

(Reporter: fryn, Assigned: fryn)

Details

Attachments

(1 file, 1 obsolete file)

In bug 840710, Matt Brubeck informed me that mobile/ doesn't use contentHandlers (the feed handlers), so I'm removing them.

There are also gecko.handlerService prefs (protocol handlers for webcal and mailto). Simply by searching the codebase for "handlerService", I was not able to confidently deduce whether mobile/ actually used those. Matt, if we don't, I can remove those too.
Attachment #724822 - Flags: review?(mbrubeck)
Comment on attachment 724822 [details] [diff] [review]
patch: remove contentHandlers from mobile/

Review of attachment 724822 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.  Possibly we could also use the related files from /mobile/android/installer/package-manifest.in.  Adding mfinkle just to double-check this patch.

I have no idea whether the handlerService prefs are used on Android; if someone wants to investigate that we could file a separate bug.
Attachment #724822 - Flags: review?(mbrubeck)
Attachment #724822 - Flags: review?(mark.finkle)
Attachment #724822 - Flags: review+
Comment on attachment 724822 [details] [diff] [review]
patch: remove contentHandlers from mobile/

With the news of Google Reader being killed and new features we might be adding to Firefox's Reader Mode, I'd like to keep these for now.

We might even revive some old patches to add Feed support to Fennec.
Attachment #724822 - Flags: review?(mark.finkle) → review-
WONTFIX'ing for now
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 724822 [details] [diff] [review]
> patch: remove contentHandlers from mobile/
> 
> With the news of Google Reader being killed and new features we might be
> adding to Firefox's Reader Mode, I'd like to keep these for now.

Why are we keeping the URL for adding to Reader/iGoogle when iGoogle is already discontinued for mobile and Reader will be discontinued in July? Removing these handler URLs has no negative future effect on Firefox for Android's ability to support feed viewing/subscription.
If you really want to remove the preferences, I'd be OK with that. Keep the py files as is, so if we add preferences back, things just work without pulling out too much hair.
I'd like to remove the prefs, because they are unused and contain non-SSL links, and they are being caught in the current sweep to move all our in-product URLs to https:// (SSL).

If/when we add subscription support back in, I highly doubt that Add to My Yahoo! in its current form will be the top choice of the future, especially on mobile.
Attachment #724822 - Attachment is obsolete: true
Attachment #725137 - Flags: review?(mark.finkle)
Comment on attachment 725137 [details] [diff] [review]
patch: just remove the prefs

thanks
Attachment #725137 - Flags: review?(mark.finkle) → review+
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a289854fe9d
Status: REOPENED → ASSIGNED
Target Milestone: --- → Firefox 22
https://hg.mozilla.org/mozilla-central/rev/0a289854fe9d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.