851053 - IonMonkey: Remove MRecompileCheck

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

It's from the time we thought we would use Ion itself as baseline compiler. With JM or baseline, it doesn't add much other than extra code/complexity.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Patch

Comment 2

[Nicolas B. Pierron [:nbp]]

Can you provide sunspider / octane results when running with --no-jm before and after the patch?  Just to check if there is not a corner case here.

Comment 3

[Jan de Mooij [:jandem]]

(In reply to Nicolas B. Pierron [:nbp] from comment #2)
> Can you provide sunspider / octane results when running with --no-jm before
> and after the patch?  Just to check if there is not a corner case here.

I can measure, but question is if we care about --no-jm. Like --ion-eager, it's not the default configuration on any platform and only there for testing purposes I think...

Comment 4

[Nicolas B. Pierron [:nbp]]

(In reply to Jan de Mooij [:jandem] from comment #3)
> (In reply to Nicolas B. Pierron [:nbp] from comment #2)
> > Can you provide sunspider / octane results when running with --no-jm before
> > and after the patch?  Just to check if there is not a corner case here.
> 
> I can measure, but question is if we care about --no-jm. Like --ion-eager,
> it's not the default configuration on any platform and only there for
> testing purposes I think...

The answer is no, we don't care, but it would be informative to know if this had any effect or not.

Comment 5

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6fdbfac4b51c

(In reply to Nicolas B. Pierron [:nbp] from comment #2)
> Can you provide sunspider / octane results when running with --no-jm before
> and after the patch?  Just to check if there is not a corner case here.

SS seems to be about 5% faster with the patch, other than that I don't see much of a difference.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6fdbfac4b51c