Repack comm-aurora using in-tree mozconfigs, objdirs, and pre-built mar tools

RESOLVED FIXED

Status

Thunderbird
Build Config
P2
critical
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: coop, Assigned: coop)

Tracking

21 Branch

Thunderbird Tracking Flags

(thunderbird21 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
These changes are going live for Firefox and comm-central today, but comm-aurora repacks will break until the patch in https://bugzilla.mozilla.org/attachment.cgi?id=720094 is uplifted.

I'll re-attach the patch here and try to flag it appropriately to get some traction.
(Assignee)

Comment 1

4 years ago
I'm trying to be conscientious and test the patch against comm-aurora. Unfortunately a straight uplift of my patch(es) from comm-central is failing, so trying to debug that. More info as I unravel it.
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
(In reply to Chris Cooper [:coop] from comment #1)
> I'm trying to be conscientious and test the patch against comm-aurora.
> Unfortunately a straight uplift of my patch(es) from comm-central is
> failing, so trying to debug that. More info as I unravel it.

Turns out it was just aurora-specific path differences in how we need to set --with-l10n-base. Patch incoming.
(Assignee)

Comment 3

4 years ago
Created attachment 725139 [details] [diff] [review]
comm-aurora changes required for repacking l10n on win64, using mozconfigs, objdirs, and pre-built mar tools

[Approval Request Comment]
Regression caused by (bug #): bug 784848
User impact if declined: comm-aurora repacks will remain disabled
Testing completed (on c-c, etc.): c-aurora in releng dev env
Risk to taking this patch (and alternatives if risky): we're uplifting of some build config code prior to merge day, but this has already happened for mozilla-aurora.
Attachment #725139 - Flags: review?(mbanner)
Attachment #725139 - Flags: approval-comm-aurora?
Comment on attachment 725139 [details] [diff] [review]
comm-aurora changes required for repacking l10n on win64, using mozconfigs, objdirs, and pre-built mar tools

+ac_add_options --with-l10n-base=../../releases/l10n/mozilla-aurora

Just a thought (and could be done with a follow-up) does this dir need to have a repo specific name? If it was repo-independent it'd mean one less change to mozconfigs on merge day (although I automate it all for comm-central anyway, so not a huge issue).
Attachment #725139 - Flags: review?(mbanner)
Attachment #725139 - Flags: review+
Attachment #725139 - Flags: approval-comm-aurora?
Attachment #725139 - Flags: approval-comm-aurora+
(Assignee)

Comment 5

4 years ago
Comment on attachment 725139 [details] [diff] [review]
comm-aurora changes required for repacking l10n on win64, using mozconfigs, objdirs, and pre-built mar tools

https://tbpl.mozilla.org/?tree=Thunderbird-Aurora&rev=ef46eb538736
(Assignee)

Comment 6

4 years ago
(In reply to Mark Banner (:standard8) from comment #4) 
> +ac_add_options --with-l10n-base=../../releases/l10n/mozilla-aurora
> 
> Just a thought (and could be done with a follow-up) does this dir need to
> have a repo specific name? If it was repo-independent it'd mean one less
> change to mozconfigs on merge day (although I automate it all for
> comm-central anyway, so not a huge issue).

We want the same thing on the Firefox side. I'll file a follow-up.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/comm-aurora/rev/ef46eb538736
status-thunderbird21: --- → fixed
You need to log in before you can comment on or make changes to this bug.