851149 - Fix sndio cubeb backend after bug 837564

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Landry Breuil (:gaston)]

Bug 837564 broke OpenBSD/sndio builds :

/var/buildslave-mozilla/mozilla-central-amd64/build/media/libcubeb/src/cubeb_sndio.c:220:22: error: use of undeclared identifier 'cubeb_onmove'
  sio_onmove(s->hdl, cubeb_onmove, s);
                     ^
/var/buildslave-mozilla/mozilla-central-amd64/build/media/libcubeb/src/cubeb_sndio.c:265:38: error: use of undeclared identifier 'cubeb_mainloop'
  err = pthread_create(&s->th, NULL, cubeb_mainloop, s);
                                     ^
1 warning and 2 errors generated.

(from http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/695/steps/build/logs/stdio)

Comment 1

[Landry Breuil (:gaston)]

Attachment: Fix sndio cubeb backend

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 724960 [details] [diff] [review]
Fix sndio cubeb backend

Sorry. :-(

To get this checked in, can you please submit a pull request upstream (http://github.com/kinetiknz/cubeb), then once it's merged use update.sh to update the in-tree version?  I can take care of this part, if you don't want to.

Comment 3

[Landry Breuil (:gaston)]

Attachment: Fix sndio cubeb backend

Done, but this is a PITA to deal with external repositories. I suppose i should change the commit message to smth totally meaningless like 'update cubeb to 21398233421efa' ?

Comment 4

[Matthew Gregan [:kinetik]]

We're in the slightly unusual situation that there have been four people making changes in parallel, so the in-tree version is slightly behind upstream right now.

I'll coordinate landing the changes with meaningful commit messages today.

Comment 5

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0044e4c2dc53

Thanks for the patch!

Comment 6

[Matthew Gregan [:kinetik]]

Backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2850e56ee75d

Probably due to bug 850713.

Comment 7

[Matthew Gregan [:kinetik]]

Relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37f55a0c903a

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/37f55a0c903a