Closed
Bug 851162
Opened 11 years ago
Closed 11 years ago
Make WrapObject in CGBindingImplClass MOZ_OVERRIDE
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: mccr8, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
3.81 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
> I wonder if we can make the WrapObject be MOZ_OVERRIDE too... Followup bug
> on that is fine; we'll need to fix ClassMethod to do that.
|
Reporter | |
Updated•11 years ago
|
Blocks: ParisBindings
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #728689 -
Flags: review?(continuation)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → bzbarsky
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [need review]
|
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 728689 [details] [diff] [review] Make the auto-generated WrapObject in JS-implemented WebIDL codegen MOZ_OVERRIDE. Review of attachment 728689 [details] [diff] [review]: ----------------------------------------------------------------- At some point we may want something like the decorators for the gunk that lies between the arguments and the open brace, but that day is not today.
Attachment #728689 -
Flags: review?(continuation) → review+
|
|
Reporter | |
Comment 3•11 years ago
|
||
Thanks for fixing this!
|
|
Assignee | |
Comment 4•11 years ago
|
||
No problem. I was in this code anyway.
|
|
Assignee | |
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/782744e0d347
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla22
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/782744e0d347
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•