Make WrapObject in CGBindingImplClass MOZ_OVERRIDE

RESOLVED FIXED in mozilla22

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mccr8, Assigned: bz)

Tracking

(Blocks: 1 bug)

unspecified
mozilla22
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
> I wonder if we can make the WrapObject be MOZ_OVERRIDE too...  Followup bug
> on that is fine; we'll need to fix ClassMethod to do that.
(Reporter)

Updated

5 years ago
Blocks: 580070
Created attachment 728689 [details] [diff] [review]
Make the auto-generated WrapObject in JS-implemented WebIDL codegen MOZ_OVERRIDE.
Attachment #728689 - Flags: review?(continuation)
Assignee: nobody → bzbarsky
Whiteboard: [need review]
(Reporter)

Comment 2

5 years ago
Comment on attachment 728689 [details] [diff] [review]
Make the auto-generated WrapObject in JS-implemented WebIDL codegen MOZ_OVERRIDE.

Review of attachment 728689 [details] [diff] [review]:
-----------------------------------------------------------------

At some point we may want something like the decorators for the gunk that lies between the arguments and the open brace, but that day is not today.
Attachment #728689 - Flags: review?(continuation) → review+
(Reporter)

Comment 3

5 years ago
Thanks for fixing this!
No problem.  I was in this code anyway.
https://hg.mozilla.org/integration/mozilla-inbound/rev/782744e0d347
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla22
https://hg.mozilla.org/mozilla-central/rev/782744e0d347
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.