Closed Bug 851170 Opened 7 years ago Closed 7 years ago

Put homescreen wallpaper feature behind confvars variable

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 22
Tracking Status
firefox22 - ---
fennec 22+ ---

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file, 1 obsolete file)

This is a follow-up to bug 844935. Instead of disabling the wallpaper feature every time there's a merge, we should just put the feature behind a variable that we can toggle.
tracking-fennec: --- → ?
We may want to roll bug 847898 into this as well, since they're both blocked on a more major permissions change (WebRTC).
We'll track the individual bugs for now - if this ends up being the agreed upon solution, we'll definitely uplift.
I am to land a patch for this before the next merge, and in that case we won't need to do any uplifting, since the feature is already hard-coded to be disabled in 20/21.
(In reply to Alex Keybl [:akeybl] from comment #1)
> We may want to roll bug 847898 into this as well, since they're both blocked
> on a more major permissions change (WebRTC).

I think it would be good to follow the same approach in these two bugs, but I think it would be simplest to keep the two features each behind their own flags.
Attached patch WIP (obsolete) — Splinter Review
This doesn't work, and I don't know why. What am I missing?
Attachment #726821 - Flags: feedback?(blassey.bugs)
Attached patch patchSplinter Review
Maybe I should change the name of this variable to indicate it's just for Android? Not sure what the conventions are here.
Attachment #726821 - Attachment is obsolete: true
Attachment #726821 - Flags: feedback?(blassey.bugs)
Attachment #726879 - Flags: review?(ted)
Comment on attachment 726879 [details] [diff] [review]
patch

Review of attachment 726879 [details] [diff] [review]:
-----------------------------------------------------------------

Up to you. The more self-documenting variables are the easier they are to deal with in the future, certainly.
Attachment #726879 - Flags: review?(ted) → review+
tracking-fennec: ? → 22+
I decided to go with MOZ_ANDROID_WALLPAPER:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b1ba9a45b82
https://hg.mozilla.org/mozilla-central/rev/5b1ba9a45b82
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
You need to log in before you can comment on or make changes to this bug.