851170 - Put homescreen wallpaper feature behind confvars variable

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

This is a follow-up to bug 844935. Instead of disabling the wallpaper feature every time there's a merge, we should just put the feature behind a variable that we can toggle.

Comment 1

[Alex Keybl [:akeybl]]

We may want to roll bug 847898 into this as well, since they're both blocked on a more major permissions change (WebRTC).

Comment 2

[Alex Keybl [:akeybl]]

We'll track the individual bugs for now - if this ends up being the agreed upon solution, we'll definitely uplift.

Comment 3

[:Margaret Leibovic]

I am to land a patch for this before the next merge, and in that case we won't need to do any uplifting, since the feature is already hard-coded to be disabled in 20/21.

Comment 4

[:Margaret Leibovic]

(In reply to Alex Keybl [:akeybl] from comment #1)
> We may want to roll bug 847898 into this as well, since they're both blocked
> on a more major permissions change (WebRTC).

I think it would be good to follow the same approach in these two bugs, but I think it would be simplest to keep the two features each behind their own flags.

Comment 5

[:Margaret Leibovic]

Attachment: WIP

This doesn't work, and I don't know why. What am I missing?

Comment 6

[:Margaret Leibovic]

Attachment: patch

Maybe I should change the name of this variable to indicate it's just for Android? Not sure what the conventions are here.

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 726879 [details] [diff] [review]
patch

Review of attachment 726879 [details] [diff] [review]:
-----------------------------------------------------------------

Up to you. The more self-documenting variables are the easier they are to deal with in the future, certainly.

Comment 8

[:Margaret Leibovic]

I decided to go with MOZ_ANDROID_WALLPAPER:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b1ba9a45b82

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5b1ba9a45b82