Closed
Bug 851171
Opened 13 years ago
Closed 8 years ago
[email] avoid flickering and add transitions for the confirms / actions sheets
Categories
(Firefox OS Graveyard :: Gaia::E-Mail, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: etienne, Unassigned)
References
Details
Attachments
(1 file)
|
3.88 KB,
patch
|
Details | Diff | Splinter Review |
We use the building blocks for confirms / action sheets.
Every time we need to display one of those we actually clone a DOM node and just append it.
This causes flickering/rough transitions.
We should add proper transitions and, if needed, re-use the dom nodes instead of cloning them.
A quick grep gives us as candidates:
Menus
* msg-contact-menu
* cmp-contact-menu
Confirms
* msg-delete-confirm
* msg-browse-confirm
* cmp-send-failed-confirm
* cmp-sending-container
* tng-accout-delete-confirm
| Reporter | ||
Comment 1•13 years ago
|
||
Attachment #728282 -
Flags: review?(dkuo)
Comment 2•12 years ago
|
||
Comment on attachment 728282 [details] [diff] [review]
Patch proposal
I didn't have chance to visit this patch and it should be out-of-date, cancelling the review request.
Attachment #728282 -
Flags: review?(dkuo)
Comment 3•12 years ago
|
||
Bug 940132 to overhaul the drawer changes our animation stuff, but does not really touch our ConfirmDialog implementation.
Vivien's proposal to use window.open for modal dialogs so it's just a system issue to do the animation correctly is also a thing, see bugs: bug 922641 and bug 923453.
Depends on: 940132
Comment 4•8 years ago
|
||
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•