851206 - javascript.options.methodjit_always set to true in safe mode

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Luke Wagner [:luke]]

I just ran across:
  http://mxr.mozilla.org/mozilla-central/source/dom/base/nsJSEnvironment.cpp#1026
where we force methodjit_always = true in safe mode.

I couldn't find any mention of this in the original bug that added this pref.  Seems like a typo and we'd want methodjit_always to be false like the rest of the jit prefs.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I don't know why I did that. It shouldn't matter though, since jitting is disabled anyway.

Comment 2

[Luke Wagner [:luke]]

Oh, that's good; I wasn't aware of how all these prefs interacted.

Comment 3

[Luke Wagner [:luke]]

Doesn't matter now that JM is gone.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Should we be removing these prefs and the JSOPTION_METHODJIT code and all its handling, then?

Comment 5

[Luke Wagner [:luke]]

Definitely; I thought this was part of Jan's general JM cleanup bug; maybe he hasn't gotten to it, I'll check with him to make sure though.

Comment 6

[Luke Wagner [:luke]]

Already done: https://hg.mozilla.org/integration/mozilla-inbound/rev/1add7f1eeb40

Comment 7

[Boris Zbarsky [:bzbarsky]]

Oh, excellent.  That's what I get for checking in a tree more than an hour old.  ;)