javascript.options.methodjit_always set to true in safe mode

RESOLVED WONTFIX

Status

()

RESOLVED WONTFIX
6 years ago
5 years ago

People

(Reporter: luke, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
I just ran across:
  http://mxr.mozilla.org/mozilla-central/source/dom/base/nsJSEnvironment.cpp#1026
where we force methodjit_always = true in safe mode.

I couldn't find any mention of this in the original bug that added this pref.  Seems like a typo and we'd want methodjit_always to be false like the rest of the jit prefs.
I don't know why I did that. It shouldn't matter though, since jitting is disabled anyway.
(Reporter)

Comment 2

6 years ago
Oh, that's good; I wasn't aware of how all these prefs interacted.
(Reporter)

Comment 3

5 years ago
Doesn't matter now that JM is gone.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
Should we be removing these prefs and the JSOPTION_METHODJIT code and all its handling, then?
Flags: needinfo?(luke)
(Reporter)

Comment 5

5 years ago
Definitely; I thought this was part of Jan's general JM cleanup bug; maybe he hasn't gotten to it, I'll check with him to make sure though.
Flags: needinfo?(luke)
Oh, excellent.  That's what I get for checking in a tree more than an hour old.  ;)
You need to log in before you can comment on or make changes to this bug.