Use canonical casing for Serbian locale script subtags (sr-Cyrl and sr-Latn)

RESOLVED FIXED in 2013Q2

Status

support.mozilla.org
Localization
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: GPHemsley, Assigned: rrosario)

Tracking

unspecified
2013Q2

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: u=user c=wiki p=1 s=2013.7)

(Reporter)

Description

5 years ago
The Serbian locales on SUMO use non-canonical casing for the script subtag in their locale codes: 'sr-CYRL' and 'sr-LATN'. (I assume this was based on legacy assumptions at some point that should have been restricted to region subtags.)

While not strictly important, I think it would be better in the long run for these locales to use the canonical casing of 'sr-Cyrl' and 'sr-Latn'. (The canonical casing for script subtags is for the first letter to be uppercase and the rest to be lowercase.)

Updated

5 years ago
Priority: -- → P3
Whiteboard: u=user c=wiki p= s=2013.7
Target Milestone: --- → 2013Q2
(Assignee)

Comment 1

5 years ago
I think we are ok with changing this in settings.py and lib/languages.json and being done. I don't *think* we have to migrate locale strings in the db:

In [3]: Document.objects.filter(locale='en-us').count()
Out[3]: 1144

In [4]: Document.objects.filter(locale='en-US').count()
Out[4]: 1144

In [5]: Document.objects.filter(locale='sr-Cyrl').count()
Out[5]: 63

In [6]: Document.objects.filter(locale='sr-cyrl').count()
Out[6]: 63
(Assignee)

Comment 2

5 years ago
Based on Comment 1, this should be an almost trivial change.
Whiteboard: u=user c=wiki p= s=2013.7 → u=user c=wiki p=1 s=2013.7
(Assignee)

Updated

5 years ago
Assignee: nobody → rrosario
(Assignee)

Comment 4

5 years ago
Landed on master:
https://github.com/mozilla/kitsune/commit/ac0b3bd6a7ac0bb03709e7b99c59cc3e42a72b2b

Deployed to prod now.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.