851224 - make install should ignore version downgrades

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch to pass the -d flag

JB throws an error for version downgrades unless you specifically override it. this makes bisecting hard amongst other things.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc796f4da835

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dc796f4da835

Comment 3

[Douglas Crosher [:dougc]]

The addition of '-d' to 'adb install' in mobile/android/build.mk caused the build_and_deploy target to fail on older Android systems.  The flag appears to be passed through to 'pm' and this fails.

Comment 4

[Mark Capella [:capella]]

Attachment: Backout the change due to regressions

Tested locally ...

Prior to change:

Verification succesful
make -s --no-print-directory -j9 -C ./objdir-droid install
560 KB/s (21598767 bytes in 37.654s)
Error: Unknown option: -d
usage: pm list packages [-f] [-d] [-e] [-s] [-3] [-i] [-u] [FILTER]
...

After change:

Verification succesful
make -s --no-print-directory -j9 -C ./objdir-droid install
606 KB/s (21598777 bytes in 34.801s)
	pkg: /data/local/tmp/fennec-22.0a1.en-US.android-arm.apk
Success

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 729013 [details] [diff] [review]
Backout the change due to regressions

Backing out because this changed has caused a lot of grief for developers when the -d is not supported on the device. We could add code to version sniff the device, but in the meantime, let's remove it.

Comment 6

[Mark Capella [:capella]]

TRY as always:
https://tbpl.mozilla.org/?tree=Try&rev=f69a3f43da9e

Comment 7

[Mark Capella [:capella]]

and then Inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a388b6b49e7

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2a388b6b49e7

Comment 9

[Chris Peterson [:cpeterson]]

build.py could check whether the device's API Level >= 17 and include then include the -d parameter:

adb shell getprop ro.build.version.sdk
17