851271 - additional Win8 reftest failures on inbound

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jim Mathies [:jimm]]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=59611a3afcb3

12:35:46 INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/svg/clipPath-and-shape-rendering-01.svg | image comparison (==), max difference: 1, number of differing pixels: 3 
12:36:57 INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/transform-3d/scale3d-all.html | image comparison (==), max difference: 143, number of differing pixels: 681
12:36:57 INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/transform-3d/scale3d-all-separate.html | image comparison (==), max difference: 143, number of differing pixels: 681 

Nothing serious, look like we just need to fuzzy a few more tests.

Comment 1

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #0)
> https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=59611a3afcb3
> 
> 12:35:46 INFO - REFTEST TEST-UNEXPECTED-FAIL |
> file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/svg/clipPath-
> and-shape-rendering-01.svg | image comparison (==), max difference: 1,
> number of differing pixels: 3 

We already annotated this 1,2 so I'll up it to 1,5.

> 12:36:57 INFO - REFTEST TEST-UNEXPECTED-FAIL |
> file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/transform-3d/
> scale3d-all.html | image comparison (==), max difference: 143, number of
> differing pixels: 681
> 12:36:57 INFO - REFTEST TEST-UNEXPECTED-FAIL |
> file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/transform-3d/
> scale3d-all-separate.html | image comparison (==), max difference: 143,
> number of differing pixels: 681 

These were already annotated for d2d but the max was set at 680. Upping that to 685.

Comment 2

[Jim Mathies [:jimm]]

Attachment: patch

Comment 3

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/94edf380da35

Comment 4

[Jim Mathies [:jimm]]

The transform-3d tests aren't fixed yet. Something in the fuzzy rules didn't catch for accelerated tests. I've pushed a new patch to try with reordered rules.

https://tbpl.mozilla.org/?tree=Try&rev=857c8082bbe6

Comment 5

[Jim Mathies [:jimm]]

Attachment: follow up

Comment 6

[Jim Mathies [:jimm]]

Comment on attachment 725456 [details] [diff] [review]
follow up

I've removed the first 'winWidget&&!layersGPUAccelerated' test, since we now fail whether we have accelerated layers or not. Plus this was tripping up the test harness somehow such that the d2d rule was being ignored.

green try run:

https://tbpl.mozilla.org/?tree=Try&rev=857c8082bbe6

Comment 7

[Jim Mathies [:jimm]]

Comment on attachment 725456 [details] [diff] [review]
follow up

ugh, wrong patch.

Comment 8

[Jim Mathies [:jimm]]

Attachment: follow up

right patch

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/94edf380da35

Comment 10

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eee0650e0d5a

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/eee0650e0d5a