Closed Bug 8513 Opened 26 years ago Closed 26 years ago

[regression] related links busted throws JS exception

Categories

(SeaMonkey :: Sidebar, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: waterson, Assigned: waterson)

Details

(Whiteboard: fix in hand. let me check in chofmann.)

Attachments

(1 file)

I debugged this; it is in fact due to Necko landing and incorrect use of nsAutoString. Jud: you replaced a call to nsAutoString::ToNewCString() with GetBuffer(). This fails because it's a two-byte string, and it has no one-byte buffer. So the string that it returns is always null. I see why you did this (to avoid cleanup code inside the #ifdef). Could you please re-examine this patch and fix?
Target Milestone: M7
Marked M7. This is a must-have feature in M7.
Attached file the fix
Assignee: valeski → waterson
Status: NEW → ASSIGNED
Whiteboard: fix in hand. let me check in chofmann.
Allright, I have a fix. Somebody please give me permission to check in.
ok.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
a=chofmann
Status: RESOLVED → VERIFIED
related links working fine in 6/19 sweetlou builds, so marking verified
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: