Closed
Bug 851459
Opened 11 years ago
Closed 11 years ago
BaselineCompiler: Don't use ScriptFrameIter in EnsureCanEnterIon
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
1.47 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
SS string-tagcloud is slower in the browser than in the shell (20 ms vs 15 ms). The problem is that we call EnsureCanEnterIon a lot and it uses ScriptFrameIter, which is slow because it has to call ExpandInlineFrames for all compartments (see also bug 851450). The patch changes EnsureCanEnterIon to use IonFrameIterator directly. I get 13.9 ms in the browser now, slightly faster than the shell even.
Attachment #725333 -
Flags: review?(kvijayan)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 725333 [details] [diff] [review] Patch Review of attachment 725333 [details] [diff] [review]: ----------------------------------------------------------------- Nice. This should in fact be a general win all around.
Attachment #725333 -
Flags: review?(kvijayan) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/projects/ionmonkey/rev/3d370087403a
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•