Closed Bug 851476 Opened 11 years ago Closed 11 years ago

mock_fb.js is encoded in Mac Roman

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g18 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g18 --- fixed

People

(Reporter: timdream, Unassigned)

Details

Attachments

(1 file)

Github: https://github.com/mozilla-b2g/gaia/pull/8673
45 bytes, text/x-github-pull-request
alive
: review+
Details | Review 
All Javascript should be encoded in UTF-8.
Alive, would you do a quick review? Thanks!
Attachment #725347 - Flags: review?(alive)
Attachment #725347 - Flags: approval-gaia-v1?
Comment on attachment 725347 [details] [review]
Github: https://github.com/mozilla-b2g/gaia/pull/8673

r+ and removing approval.
Attachment #725347 - Flags: review?(alive)
Attachment #725347 - Flags: review+
Attachment #725347 - Flags: approval-gaia-v1?
Hi Jose,

I've only scanned JS files with |js -c|, so you might want to chack other files you checked in around the time you fix bug 796604. Thanks!
Flags: needinfo?(jmcanterafonseca)
https://github.com/mozilla-b2g/gaia/commit/8accbbb49b1b67fd7b93194e07e6bf017e0c90c3

Fixed in master
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
yes, we need to check all the files and maybe make a global PR to fix that. the problem was Komodo v6 editor. Komodo v7 does not have such a problem.
(In reply to Jose M. Cantera from comment #5)
> yes, we need to check all the files and maybe make a global PR to fix that.
> the problem was Komodo v6 editor. Komodo v7 does not have such a problem.

but that it is not on the top of my priorities.
(In reply to Jose M. Cantera from comment #6)
> (In reply to Jose M. Cantera from comment #5)
> > yes, we need to check all the files and maybe make a global PR to fix that.
> > the problem was Komodo v6 editor. Komodo v7 does not have such a problem.
> 
> but that it is not on the top of my priorities.

No worries, until some wired bug turned up :-)
Flags: needinfo?(jmcanterafonseca)
This is npotb and is blocking an approved patch from landing on v1-trian.

v1-train: d04628b
status-b2g18: --- → fixed
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: