Closed
Bug 851548
Opened 13 years ago
Closed 13 years ago
Launching app broken if user serial not sent back via agent
Categories
(Testing :: Mozbase, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
Details
Attachments
(1 file)
|
4.19 KB,
patch
|
mcote
:
review+
|
Details | Diff | Splinter Review |
Currently we break if we try to launch an app via "droid" if there is no user serial sent back from the agent. This was a simple logic error, easily correctable. I'll add some unit tests to catch this case as well.
|
Assignee | |
Comment 1•13 years ago
|
||
Pretty straightforward stuff. I took the liberty of privatizing the userSerial variable (which is really for internal use only) at the same time.
Attachment #725441 -
Flags: review?(mcote)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 725441 [details] [diff] [review]
Fix launching apps when no user serial present
Review of attachment 725441 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good.
Attachment #725441 -
Flags: review?(mcote) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•