Memory leak in UnixSocketConsumer

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ericchou, Assigned: ericchou)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Caller passes UnixSocketConnector instance into UnixSocketConsumer::ListenSocket() and UnixSocketConsumer::ConnectSocket(), in general cases, after an UnixSocketImpl instance is created, it will in charge of deleting the UnixSocketConnector instance by holding it with a nsAutoPtr. However, at the beginning of these two functions, it would check if mImpl already exists. If it does, then return - without deleting the UnixSocketConnector instance.
(Assignee)

Updated

5 years ago
Assignee: nobody → echou
(Assignee)

Comment 1

5 years ago
Created attachment 725483 [details] [diff] [review]
patch 1: v1: fix memory leak in UnixSocketConsumer
Attachment #725483 - Flags: review?(kyle)
Attachment #725483 - Flags: review?(kyle) → review+
(Assignee)

Comment 2

5 years ago
try: https://tbpl.mozilla.org/?tree=Try&rev=538b9e479642
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c8569d8e01e

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/5c8569d8e01e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.