851564 - Refactor nsSocketTransport2 and DNSService 2 and remove aStrict from nsMainThreadPtrHolder API

Status: NEW

(Core :: Networking, defect, P5)

Description

[Bobby Holley (:bholley)]

For bug 850252 and bug 850245, I had to add a special API to nsMainThreadPtrHolder to disable strict enforcement of threading invariants. The basic problem in both cases is that we store a variety of objects in a given pointer. Sometimes this object is an XPCWrappedJS, and may not be accessed off-main-thread. But sometimes it's a threadsafe object, and we _do_ access it off-main-thread.

bsmedberg points out in bug 850054 comment 4 that this feels like a design bug, and that we should have clearer invariants regarding when we do and do not access these things off-main-thread. But I want to get this landed now, hence the followup bug.

Comment 1

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 2

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, >=3 years untouched DOM/Storage bug's priority.

If you have reason to believe this is wrong, please write a comment and ni :jstutte.