851591 - Add a main-end hook into global/footer.html.tmpl to be able to display additional data before displaying the page footer

Status: RESOLVED FIXED

(Bugzilla :: Extensions, enhancement)

Description

[Frédéric Buclin]

Attachment: patch, v1

The current hooks in global/footer.html.tmpl all affect the page footer itself but do not let a developer add stuff before the page footer is displayed, see e.g. bug 842045 and bug 842159. I add a 'main-end' hook before the page footer and also add a new template to the Example extension to show how to get the name of the template being processed (I use the existing 'end' hook for that, to not clutter the page itself).

Comment 1

[Frédéric Buclin]

Comment on attachment 725506 [details] [diff] [review]
patch, v1

timello doesn't seem to be around anymore.

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 725506 [details] [diff] [review]
patch, v1

Review of attachment 725506 [details] [diff] [review]:
-----------------------------------------------------------------

I think you meant to name the example template hook extensions/Example/template/en/default/hook/global/footer-main-end.html.tmpl instead. Fix on commit. r=dkl

Comment 3

[Frédéric Buclin]

(In reply to David Lawrence [:dkl] from comment #2)
> I think you meant to name the example template hook
> extensions/Example/template/en/default/hook/global/footer-main-end.html.tmpl
> instead.

No. As I said in comment 0, I don't want to display data in the page itself, but only below the page footer.

Comment 4

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
added extensions/Example/template/en/default/hook/global/footer-end.html.tmpl
modified template/en/default/global/footer.html.tmpl
Committed revision 8614.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
added extensions/Example/template/en/default/hook/global/footer-end.html.tmpl
modified template/en/default/global/footer.html.tmpl
Committed revision 8547.

Comment 5

[David Lawrence [:dkl]]

(In reply to Frédéric Buclin from comment #3)
> (In reply to David Lawrence [:dkl] from comment #2)
> > I think you meant to name the example template hook
> > extensions/Example/template/en/default/hook/global/footer-main-end.html.tmpl
> > instead.
> 
> No. As I said in comment 0, I don't want to display data in the page itself,
> but only below the page footer.

Ah ok. Missed that point in comment 0. I tried the template in both locations and it worked all the same. 

dkl