Closed Bug 851672 Opened 7 years ago Closed 6 years ago

Rename quitApplicationCmdMac.key to reflect reuse on Linux

Categories

(Firefox Graveyard :: Web Apps, defect, P3, trivial)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: mconley, Assigned: marco)

Details

Attachments

(1 file)

We fixed this in /browser in bug 420371, but it appears that a similar bug exists under /webapprt.

quitApplicationCmdMac.key's entity name suggests that it is for us on OSX only, when in fact it is used by both OSX and Linux builds.

We renamed the entity to quitApplicationCmdUnix.key in bug 420371, and we might want to do the same in /webapprt as well.
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #788291 - Flags: review?(mconley)
Comment on attachment 788291 [details] [diff] [review]
rename_quitApplicationCmdMac.key

This looks fine to me - but we should get someone who can review webapprt stuff to look at this.
Attachment #788291 - Flags: review?(mconley) → feedback+
Priority: -- → P3
Comment on attachment 788291 [details] [diff] [review]
rename_quitApplicationCmdMac.key

Review of attachment 788291 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine to me. I don't know our localization process very well, but I believe that the "Localization Note" will bring this to their attention if there are any issues with this patch.
Attachment #788291 - Flags: review?(tabraldes) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c97cd5608de6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.