Closed Bug 851689 Opened 9 years ago Closed 9 years ago

Toolbox Tabs extra wide after the Sidebar adaptation fix (bug 818151)

Categories

(DevTools :: Framework, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 22

People

(Reporter: Optimizer, Assigned: miker)

References

()

Details

Attachments

(1 file)

See the url to see what I am talking about :)

The max-width of the tabs is too much, and due to flex, they take up all the space.
Shorlander, our UX guy and Paul both okayed them.

What do you guys think?
Paul only asked me to open this bug :)
I agree they're too wide.
Is it wider than before? If so, we should fix that.
(In reply to Paul Rouget [:paul] from comment #4)
> Is it wider than before? If so, we should fix that.

This is a pic from before I updated my fx-team : https://pbs.twimg.com/media/BFRKkxQCEAEZdBb.jpg:large

This is from after : https://bug851546.bugzilla.mozilla.org/attachment.cgi?id=725684
Indeed. Let's fix that.
We also have issues on Linux: bug 852019
Assignee: nobody → mratcliffe
It will look better if we tighten up the max-width as much as possible and center the icon+label.
Attached patch PatchSplinter Review
Tweaked width and margins as Shorlander suggested. Also tweaked the icon padding so now it looks far better when docked to the side of the browser.

I am much happier with this.
Attachment #726618 - Flags: review?(jwalker)
Looks fine on OSX, Windows & Linux btw.
Attachment #726618 - Flags: review?(jwalker) → review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/8caaaf8e1894
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 22
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.