851689 - Toolbox Tabs extra wide after the Sidebar adaptation fix (bug 818151)

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Girish Sharma [:Optimizer]]

See the url to see what I am talking about :)

The max-width of the tabs is too much, and due to flex, they take up all the space.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Shorlander, our UX guy and Paul both okayed them.

What do you guys think?

Comment 2

[Girish Sharma [:Optimizer]]

Paul only asked me to open this bug :)

Comment 3

[Victor Porof [:vporof][:vp]]

I agree they're too wide.

Comment 4

[Paul Rouget [:paul]]

Is it wider than before? If so, we should fix that.

Comment 5

[Girish Sharma [:Optimizer]]

(In reply to Paul Rouget [:paul] from comment #4)
> Is it wider than before? If so, we should fix that.

This is a pic from before I updated my fx-team : https://pbs.twimg.com/media/BFRKkxQCEAEZdBb.jpg:large

This is from after : https://bug851546.bugzilla.mozilla.org/attachment.cgi?id=725684

Comment 6

[Paul Rouget [:paul]]

Indeed. Let's fix that.

Comment 7

[Paul Rouget [:paul]]

We also have issues on Linux: bug 852019

Comment 8

[Stephen Horlander [:shorlander]]

It will look better if we tighten up the max-width as much as possible and center the icon+label.

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch

Tweaked width and margins as Shorlander suggested. Also tweaked the icon padding so now it looks far better when docked to the side of the browser.

I am much happier with this.

Comment 10

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Looks fine on OSX, Windows & Linux btw.

Comment 11

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://hg.mozilla.org/integration/fx-team/rev/8caaaf8e1894

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/8caaaf8e1894