851692 - clock on homescreen is out of date from when screen turned on until next minute ticks (or a little sooner)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When I press the power button on the phone and unlock it, the clock on the homescreen shows an out-of-date time until the next change in minute.  This is really bad; one of the common things people the clock on the homescreen for is to check what time it is.

Steps to reproduce:
 1. don't use the phone for a few minutes
 2. press the power button
 3. unlock the phone
 4. look at the clock on the homescreen

I'm seeing this on a self-built user build of v1-train for Otoro, built from earlier today.

I'll attach a screenshot shortly.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: screenshot

The clock in the upper left (3:27PM) is correct.  The big clock in the middle (3:05PM) is wrong.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'd note, however, that the lockscreen is correct when this happens; it's the clock on the homescreen *after* unlocking that's wrong.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

And I'm reasonably confident this regressed within the past few weeks.

Comment 4

[Cristian Rodriguez (:crdlc)]

I cannot reproduce after uplifting this one

https://github.com/mozilla-b2g/gaia/commit/95d5b5125a81f14b985fd8b2d919718fb35e8933

Please reopen if you find the same problem, thanks

Comment 5

[Cristian Rodriguez (:crdlc)]

I am sure that it was the problem because if you see the screenshot there is not orange bar on the top :)

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Should that also be uplifted to v1.0.1, or is it not a problem there?

Comment 7

[Cristian Rodriguez (:crdlc)]

Yes, and it was uplifted as well. See

https://bugzilla.mozilla.org/show_bug.cgi?id=837062#c22

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: new screenshot

Although I hadn't seen it for a few days (though I hadn't been using my phone much because of bug 850175), I'm seeing this again on v1-train, specifically with:
  gaia a78ebf426840b5ef08c0cc3e437ad30aba3e2528
  gecko 115b32b8f8fc435a0ddc31a0f7dc755ab5f609ca

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

That said, I've also seen cases where it gets better sooner than the next minute tick.

Comment 10

[Cristian Rodriguez (:crdlc)]

Please STR. E.g. I stay in landing page, the phone goes away and after unlocking the date is wrong.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The steps to reproduce in comment 0 show the bug more often than not for me.  (I'm guessing when they don't it's because the phone has been active.)

In case it makes a difference:
 * I do have a lock code enabled
 * When I lock the phone, it's typically on the "Home" screen (i.e., the screen I get after pressing the home button, which is the one with the clock)

Comment 12

[Cristian Rodriguez (:crdlc)]

I am going to try to reproduce the bug with current v1-train, thanks

Comment 13

[Cristian Rodriguez (:crdlc)]

Attachment: This patch forces to update the time when homescreen goes from background to foreground

Hi David, I cannot reproduce the problem but I've created a patch in order to force always the update of the time when the homescreen goes to background to foreground. Could you test this patch?

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think the patch helps.  I've checked my phone three or four times over the course of the afternoon, with the patch applied, and haven't seen the bug yet.

Comment 15

[Cristian Rodriguez (:crdlc)]

ok, if you cannot reproduce the problem with this patch we could land this one as solution for our bug, are you agree? thanks

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 728901 [details] [diff] [review]
This patch forces to update the time when homescreen goes from background to foreground

Sounds good to me -- assuming the patch gets appropriate reviews (and if needed, approvals), of course.

Comment 17

[Daniel Coloma:dcoloma]

Given this problem has been only reproduced in v1-train I suggest we land this in master (after r+) and request approval or leo nomination. If someone can reproduce it in v1.0.1 we will request uplift for 1.0.1.

Comment 18

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Patch to the rescue

Comment 19

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/45506a722460094cd69e8fa419874cf2eb73fa2e

Comment 21

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 45506a722460094cd69e8fa419874cf2eb73fa2e as:
v1-train: bba9a840a261e2503b95482e6cce2927e1f9f398

Comment 23

[Daniel Coloma:dcoloma]

It seems that is has been reproduced in v1.0.1 too (see bug 859790) marking tef+ and affected.

Comment 24

[Sreenidhi]

Tested on an Inari using the following build :

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/c3ee6b445cf5
Gaia   393a946b9d60294697838c5ef7e0548d47c3281a
BuildID 20130419070202
Version 18.0

Could not reproduce it.

Comment 25

[James Lal [:lightsofapollo]]

Can't uplift directly to v1.0.1 because of conflicts... please needinfo me if you need help uplifting.

Comment 26

[Cristian Rodriguez (:crdlc)]

v1.0.1: 07b934544bcb2ec953bafd5c4ffced721d9ec4df

Comment 27

[Sarah Parsons]

This issue has been verified fixed on Leo Build ID: 20130426070204

Environmental  Variables:
Kernel Date: Mar 15
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6c2493de1441
Gaia: c9046a7acef33328977840176ff5574720d2c74c

This issue has also been verified fixed on Inari Build ID: 20130429070204

Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/45aa5ba0ed53
Gaia: cf2d4136f0ebc66039637fdbeb72ed184dfbc0f2