851720 - l10n build issues on central and aurora

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Axel Hecht [:Pike]]

Being on PTO, just a quick report:

https://aus3.mozilla.org/update/3/Firefox/22.0a1/20130314030914/Darwin_x86_64-gcc3-u-i386-x86_64/de/nightly/Darwin%2011.4.2/default/default/update.xml?force=1 comes out empty, but there are mac german nightlies from the 15th.

Also, I see a host of burning depend builds on aurora, and windows nightlies seem to be busted, too. error message there is a missing l10n repo, it seems,

*** Fix above errors and then restart with               "C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/build/pymake/pymake/../make.py -f client.mk build"
e:\builds\moz2_slave\m-aurora-w32-l10n-ntly-0000000\build\mozilla-aurora\client.mk:321:0: command 'cd obj-firefox &&  MAKE="C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/build/pymake/pymake/../make.py"  e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/configure  \
  || ( echo "*** Fix above errors and then restart with\
               \"C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-aurora-w32-l10n-ntly-0000000/build/mozilla-aurora/build/pymake/pymake/../make.py -f client.mk build\"" && exit 1 )' failed, return code 1
configure: error: Invalid value --with-l10n-base, ../../l10n-central doesn't exist

Comment 1

[Aki Sasaki (not active)]

I'm going to guess this is a bad mozconfig from merge day.

Comment 2

[Chris Cooper [:coop] (he/him)]

The comm-aurora patch in bug 851117 already has a fix for this issue for Thunderbird:

https://bugzilla.mozilla.org/attachment.cgi?id=725139

Comment 3

[Chris Cooper [:coop] (he/him)]

Attachment: Fix aurora path for --with-l10n-base in mozconfigs

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 784848
User impact if declined: repacks on m-a will remain broken
Testing completed (on m-c, etc.): releng rev env
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none

Comment 4

[Chris Cooper [:coop] (he/him)]

I should note that until we can do something more intelligent with paths like these in the mozconfigs, we'll need to add this to the merge day docs for relman.

Comment 5

[Axel Hecht [:Pike]]

Any news on the lack up updates on mac nightlies? https://aus3.mozilla.org/update/3/Firefox/22.0a1/20130314030914/Darwin_x86_64-gcc3-u-i386-x86_64/de/nightly/Darwin%2011.4.2/default/default/update.xml?force=1 isn't showing updates being available.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Axel Hecht [:Pike] from comment #5)
> Any news on the lack up updates on mac nightlies?

Axel, that might be related to bug 851539 where updates have been disabled for Nightly.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

The Relman merge docs are here: https://wiki.mozilla.org/Release_Management/Merge_Documentation

Please let us know which branch merges will need to make changes to this line (ie: is beta also going to be affected?).

Comment 8

[Chris Cooper [:coop] (he/him)]

(In reply to Lukas Blakk [:lsblakk] from comment #7)
> The Relman merge docs are here:
> https://wiki.mozilla.org/Release_Management/Merge_Documentation
> 
> Please let us know which branch merges will need to make changes to this
> line (ie: is beta also going to be affected?).

We only use these l10n-mozconfigs for m-c and m-a right now, so the only merge affected would be m-c -> m-a. 

We would like to use mozconfigs for beta and release eventually, but I would like to eliminate the need for branch-specific l10n-base dirs before we get to that point. I'll be filing a separate bug tomorrow for that.

Comment 9

[Chris Cooper [:coop] (he/him)]

(In reply to Chris Cooper [:coop] from comment #8)
> We would like to use mozconfigs for beta and release eventually, but I would
> like to eliminate the need for branch-specific l10n-base dirs before we get
> to that point. I'll be filing a separate bug tomorrow for that.

i.e. There would be no extra merge activity after this change. I want to make the l10n checkout live under a standard dir across branches, say simply 'l10n.' I'm hoping to get this fixed 

Ping re: the uplift approval request. Repacks are broken on m-a instead until we get this patch. 

mozilla-central repacks are working again as of this morning.

Comment 10

[Chris Cooper [:coop] (he/him)]

(In reply to Chris Cooper [:coop] from comment #9)
> i.e. There would be no extra merge activity after this change. I want to
> make the l10n checkout live under a standard dir across branches, say simply
> 'l10n.' I'm hoping to get this fixed 

Filed bug 852553.

Comment 11

[bhavana bajaj [:bajaj]]

Comment on attachment 725679 [details] [diff] [review]
Fix aurora path for --with-l10n-base in mozconfigs

low risk patch that avoids broken Repacks on m-a , approving for uplift

Comment 12

[Chris Cooper [:coop] (he/him)]

Comment on attachment 725679 [details] [diff] [review]
Fix aurora path for --with-l10n-base in mozconfigs

https://hg.mozilla.org/releases/mozilla-aurora/rev/e47f2c235959

Comment 13

[Chris Cooper [:coop] (he/him)]

We had successful repacks on aurora last night.