851751 - hotfix for issue 3091 - please deploy 2013.03.01 to stage

Status: RESOLVED FIXED

(Cloud Services :: Operations: Deployment Requests - DEPRECATED, task)

Description

[John Morrison [:jrgm]]

+++ This bug was initially created as a clone of Bug #846928 +++

Hotfix: https://github.com/mozilla/browserid/issues/3091

sha: 0d62ce679f27834002d0ca5b57d31f6e1349b6b2

svn locale: 113972

Changelog: https://github.com/mozilla/browserid/blob/train-2013.03.01/ChangeLog#L1-L12

Schedule: http://personatra.in/#2013.03.01

Comment 1

[John Morrison [:jrgm]]

Build command:

$ ./build.sh browserid train-2013.03.01 0d62ce679f27834002d0ca5b57d31f6e1349b6b2 113972

Output rpm on build machine r6:

/home/jrgm/workspace/browserid/rpmbuild/RPMS/x86_64/browserid-server-0.2013.03.01-2.el6_113972.x86_64.rpm

Comment 2

[John Morrison [:jrgm]]

Deployed to production with command:
./distribute_and_install.sh browserid train-2013.03.01

$ for i in `seq 100`; do curl -s https://login.anosrep.org/ver.txt; done | sort | uniq -c
 100 0d62ce6 document hotfixes in 0.2013.03.01.2                                                               
 100 locale svn r113972  

Ready for testing.

Comment 3

[John Morrison [:jrgm]]

Also, I used https://bugzilla-dev.allizom.org/index.cgi to signin as an existing secondary, and as a yahoo.com address. Works.

Comment 4

[John Morrison [:jrgm]]

Notes:
- for i in `seq 100`; do curl -s https://login.anosrep.org/ver.txt; done | sort | uniq -c
 100 0d62ce6 document hotfixes in 0.2013.03.01.2                                                               
 100 locale svn r113972  
- for i in `seq 100`; do curl -s https://login.anosrep.org/sign_in | egrep 'Current|dialog.js|dialog.css'; done | sort | uniq -c
 100         <script src="https://static.login.anosrep.org/v/41021c12ef/production/en/dialog.js"></script>
 100     <link href="https://static.login.anosrep.org/v/844b6f3f18/production/ie8_dialog.css" rel="stylesheet" type="text/css">
 100    - Current Commit: https://github.com/mozilla/browserid/commit/0d62ce6
 100   <link href="https://static.login.anosrep.org/v/a7b294ecd6/production/en/dialog.css" rel="stylesheet" type="text/css">
- for i in `seq 100`; do curl -s https://login.anosrep.org/.well-known/browserid; echo; done | sort | uniq -c
  returns a public-key, no 500 error.
- for i in {web,sweb,sign}{1,2,3}; do ssh $i 'node --version'; done | sort | uniq -c
    9 v0.8.17
- for i in {web,sweb,sign}{1,2,3}; do ssh $i 'sudo svstat /service/browserid*'; done
  for i in {web,sweb,sign}{1,2,3}; do ssh $i "ps -eo pid,lstart,bsdtime,pcpu,pri,rsz,vsz,command | grep 'node bin/' | grep -v grep"; done
  shows the processes restarted and not flapping
- travis tests pass at this branch point - https://travis-ci.org/mozilla/browserid/builds/5540556
- not running load_gen for this fix.

Comment 5

[John Morrison [:jrgm]]

In https://bugzilla.mozilla.org/show_bug.cgi?id=851000#c17, I mentioned that this push picks up a critical fix from https://github.com/mozilla/browserid/issues/3091.

I've run the automation-tests with 100% passing for linux_firefox, win7_firefox and win7_chrome (the others have various issues to fix still).

I'd like to get a good pass with sanity checking the various browsers manually before pushing this out, likely tomorrow. Specific attention to STR at https://github.com/mozilla/browserid/issues/3091#issuecomment-14991324 should be done (on the browsers where it is feasible to do so).

Comment 6

[John Morrison [:jrgm]]

Okay, been juggling various things. But I'm good with this in stage. We were released before but reverted first due to the bugzilla networking fail, and then for
https://github.com/mozilla/browserid/issues/3091. 

I'll follow up with a ticket to deploy this build to production tomorrow. I'm signing off on this rpm.