Closed
Bug 851768
Opened 13 years ago
Closed 12 years ago
Add-on SDK tutorial for setting about:config entries
Categories
(Add-on SDK Graveyard :: Documentation, defect, P3)
Add-on SDK Graveyard
Documentation
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: arky, Assigned: wbamberg)
Details
Attachments
(1 file)
|
1011 bytes,
patch
|
mossop
:
review+
arky
:
feedback+
|
Details | Diff | Splinter Review |
Please provide tutorial to toogle about:config entries (http://kb.mozillazine.org/About:config_entries)
Is the preferences/service documentation sufficient? https://addons.mozilla.org/en-US/developers/docs/sdk/latest/modules/sdk/preferences/service.html
Flags: needinfo?(hitmanarky)
| Reporter | ||
Comment 2•13 years ago
|
||
(In reply to Wes Kocher (:KWierso) from comment #1)
> Is the preferences/service documentation sufficient?
> https://addons.mozilla.org/en-US/developers/docs/sdk/latest/modules/sdk/
> preferences/service.html
Yes, That is good. Perhaps we make it into a tutorial here:
https://addons.mozilla.org/en-US/developers/docs/sdk/latest/dev-guide/tutorials/index.html
Flags: needinfo?(hitmanarky)
Will, what do you think?
Flags: needinfo?(wbamberg)
| Assignee | ||
Comment 4•13 years ago
|
||
I think there are 2 reasons to have a tutorial on something as well as an API reference page:
1) primary reason: to provide a simple way into a complex API such as panel or page-mod.
2) secondary reason: to help make content discoverable: someone who wants to add a button might not find the "widget" module, so having a page that lists common tasks like this makes it easier to get started. Having a search function makes this reason matter less.
I'd be interested to know why Arky thinks a tutorial is needed as well as the preferences/service API page. I think it's too simple an API to need a tutorial for reason (1), so perhaps it's reason (2) - that it was hard to find the reference page? If so, maybe just adding a reference to "about:config" in the API page would do it, since then a search would turn it up?
I think we could more usefully have a tutorial on simple-prefs, since that is a more complex API. And that could mention preferences/service too. But I think users see these as very distinct APIs, although they share the implementation - one is for my settings, the other is for configuring the browser.
Flags: needinfo?(wbamberg)
Flags: needinfo?(hitmanarky)
Priority: -- → P3
| Reporter | ||
Comment 5•13 years ago
|
||
I agree that API is quite simple. Just learnt of its existence in this bug. This is most common request I got after my Addon-SDK workshop.
Flags: needinfo?(hitmanarky)
| Assignee | ||
Comment 6•13 years ago
|
||
Attachment #738549 -
Flags: review?(dtownsend+bugmail)
Attachment #738549 -
Flags: feedback?(hitmanarky)
| Assignee | ||
Comment 7•13 years ago
|
||
So here's my suggested patch for this: I've added a line of text to the start of the API reference for preferences/service that mentions about:config.
From your bug report, arky, it sounds like people were specifically looking for "about:config": this change ought to cause the page to show up in a search for about:config, so should make the API more discoverable.
Assignee: nobody → wbamberg
Comment 8•13 years ago
|
||
Comment on attachment 738549 [details] [diff] [review]
add reference to about:config
Review of attachment 738549 [details] [diff] [review]:
-----------------------------------------------------------------
Happy to take as-is though see what you think about my suggestion.
::: doc/module-source/sdk/preferences/service.md
@@ +15,4 @@
>
> To define preferences for your own add-on and expose them to the user in
> the [Add-on Manager](https://developer.mozilla.org/en-US/docs/Addons/Add-on_Manager),
> +you can use the [simple-prefs](modules/sdk/simple-prefs.html) module instead.
Instead doesn't sound exactly right to me as really it's "in addition to". I wonder if this paragraph would be better written something like:
While `preferences/service` gives you full access to the preferences system you can also use the simple-prefs module to access just the preferences for your own add-on and expose them to the user in the Add-on Manager.
Attachment #738549 -
Flags: review?(dtownsend+bugmail) → review+
| Reporter | ||
Comment 9•12 years ago
|
||
Comment on attachment 738549 [details] [diff] [review]
add reference to about:config
Looks good +1
| Reporter | ||
Comment 10•12 years ago
|
||
Comment on attachment 738549 [details] [diff] [review]
add reference to about:config
Looks good. Thanks!
r+
Attachment #738549 -
Flags: feedback?(hitmanarky) → feedback+
| Assignee | ||
Comment 11•12 years ago
|
||
Updated, finally, here: https://developer.mozilla.org/en-US/Add-ons/SDK/Low-Level_APIs/preferences_service .
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•