Ensure Builder doesn't reject "permissions" key in package.json.

RESOLVED FIXED in 2013-04-18

Status

addons.mozilla.org Graveyard
Add-on Builder
--
major
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: KWierso, Assigned: canuckistani)

Tracking

unspecified
2013-04-18

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
When I try to pre-emptively prepare a Builder-based addon for the new private-browsing permissions, I get the following error upon adding {"permissions": {"private-browsing": true}} in the "Extra package.json Properties" textbox in the addon's Properties popup:


Error 403

FORBIDDEN
'Invalid key.
allowed keys: contributors, homepage, icon, icon64, id, preferences, license'



I'm not sure offhand if that list of allowed keys is generated automatically from the SDK version, or if it's hardcoded into Builder.

We should make sure that it works correctly regardless once 1.14 is added to Builder.
(Reporter)

Comment 1

5 years ago
Created attachment 725726 [details] [diff] [review]
Add "permissions" key to the list of allowed keys.

So it is managed by Flightdeck's code.

This will need to be committed and deployed before (or with) the addition of SDK 1.14 on or near March 28.
Attachment #725726 - Flags: review?(zaloon)
(Reporter)

Comment 3

5 years ago
This got merged in a while back.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Assignee: nobody → jgriffiths
Target Milestone: --- → 2013-04-18
(Reporter)

Updated

4 years ago
Attachment #725726 - Flags: review?(pzalewa)
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.