851778 - Ensure Builder doesn't reject "permissions" key in package.json.

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

When I try to pre-emptively prepare a Builder-based addon for the new private-browsing permissions, I get the following error upon adding {"permissions": {"private-browsing": true}} in the "Extra package.json Properties" textbox in the addon's Properties popup:


Error 403

FORBIDDEN
'Invalid key.
allowed keys: contributors, homepage, icon, icon64, id, preferences, license'



I'm not sure offhand if that list of allowed keys is generated automatically from the SDK version, or if it's hardcoded into Builder.

We should make sure that it works correctly regardless once 1.14 is added to Builder.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Add "permissions" key to the list of allowed keys.

So it is managed by Flightdeck's code.

This will need to be committed and deployed before (or with) the addition of SDK 1.14 on or near March 28.

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

That link again is: https://github.com/mozilla/FlightDeck/pull/186

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This got merged in a while back.