Closed Bug 851785 Opened 9 years ago Closed 9 years ago

FrameRect triggers decoding

Categories

(Core :: ImageLib, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: tnikkel, Assigned: tnikkel)

References

(Depends on 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

We trigger a decode for basically every image we download because imgStatusTracker::SyncNotify calls FrameRect on the image, which asks for decoded frames, which triggers a decode. This is the only caller of FrameRect, so it shouldn't be a problem to make FrameRect not ask for decoded frames.
This causes some of our async_load_tests.js tests to fail for a very simple reason: without this inadvertent decode we don't trigger a decode at all in these tests. But checkAllCallbacks wants us to be decoded fully.

Should we insert a requestDecode in this test or just not check if the image is decoded?
Flags: needinfo?(joe)
(In reply to Timothy Nikkel (:tn) from comment #1)
> But checkAllCallbacks wants us to be decoded fully.

We only check this on a static request. So maybe we only have these expectations of being fully decoded on static requests? Before bug 843895 that was always true because static requests used ExtractFrame with sync decode, but after bug 843895 we just wrap them in a wrapper that always returns the first frame.
Talked to Joe on irc about this.
Flags: needinfo?(joe)
Attachment #726301 - Flags: review?
Attachment #726301 - Attachment is obsolete: true
Attachment #726301 - Flags: review?
Attachment #726303 - Flags: review?
Attachment #726298 - Flags: review? → review+
Attachment #726303 - Flags: review? → review+
https://hg.mozilla.org/mozilla-central/rev/9502b3cccfe3
https://hg.mozilla.org/mozilla-central/rev/25c76053d44a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Depends on: 853774
Depends on: 932277
You need to log in before you can comment on or make changes to this bug.