Closed Bug 851814 Opened 9 years ago Closed 9 years ago

SharedLibrary's ctor can clobber the high word of the address and offsets on Win64

Categories

(Core :: Gecko Profiler, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

Attachments

(1 file)

Attached patch Patch (v1)Splinter Review
No description provided.
Attachment #725782 - Flags: review?(jmuizelaar)
Attachment #725782 - Flags: review?(bgirard)
Comment on attachment 725782 [details] [diff] [review]
Patch (v1)

Review of attachment 725782 [details] [diff] [review]:
-----------------------------------------------------------------

Easy
Attachment #725782 - Flags: review?(jmuizelaar) → review+
Comment on attachment 725782 [details] [diff] [review]
Patch (v1)

Thanks for the review Jeff.  I may send a bunch of more requests to you today and tomorrow, I'd appreciate if you can take a look at them.  :-)
Attachment #725782 - Flags: review?(bgirard)
https://hg.mozilla.org/mozilla-central/rev/d926c77d4cd7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.