851842 - Fix suggestions for jit-tests.py

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Phil Ringnalda (:philor)]

Because every single test suite has to be a unique snowflake, and most of them have to be unique like teenage juvenile delinquents, by breaking something, jit-tests.py outputs errors like

TEST-UNEXPECTED-FAIL | jit_test.py --no-ion | /builds/slave/m-in_l64-d_sm-rootanalysis-000/src/js/src/jit-test/tests/jaeger/bug738525.js: Assertion failure: !js::IsPoisonedPtr(l), at /builds/slave/m-in_l64-d_sm-rootanalysis-000/objdir/dist/include/js/HashTable.h:489

where as far as tbpl is concerned, the failing test is named "jit_test.py --no-ion" and it should suggest intermittent-failure bugs with that in the summary, and there's certainly no reason to suggest bugs which do not have --no-ion, or bugs which have --no-ion --no-monkeybusiness.

Sweet solution: someone says "oh, gosh, I didn't realize that was semi-structured reverse-engineered data, we can just put the actual filename in between the first and second pipe characters so tbpl can see it."

Better than nothing solution: tbpl special-cases jit-test.py and looks for the filename beyond the second pipe.

Comment 1

[Ed Morley [:emorley]]

Thank you for filing this - I was musing over this the other day.

I'm inclined to go for the 'change the harness output to match every other' approach.

Something like:
TEST-UNEXPECTED-FAIL | /builds/slave/m-in_l64-d_sm-rootanalysis-000/src/js/src/jit-test/tests/jaeger/bug738525.js | no-ion: Assertion failure: ...

Comment 2

[Ed Morley [:emorley]]

Attachment: Patch v1

Current output format is in comment 0.

This patch makes it like:
 TEST-PASS | /foo/bar/baz.js | --no-jm
 TEST-UNEXPECTED-FAIL | /foo/bar/baz.js | --no-ion: Assertion failure: ...
 TEST-UNEXPECTED-FAIL | jit_test.py: Test execution interrupted by user

This means TBPL can search on baz.js for the 2nd example, avoiding the current situation where the search for jit_test.py returns too many results. In the 3rd example format, TBPL will fallback to searching for the full line (since tokens after splitting on the pipe symbol < 3).

Comment 3

[Ed Morley [:emorley]]

https://tbpl.mozilla.org/?tree=Try&rev=c66428f23721

Comment 4

[Terrence Cole [:terrence]]

Comment on attachment 725826 [details] [diff] [review]
Patch v1

Review of attachment 725826 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome! I had no idea this was problematic or I would have fixed it ages ago.

Comment 5

[Ed Morley [:emorley]]

Thank you for the review :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/865a2157b608

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/865a2157b608