851860 - SyntaxError in Calendar unit test scripts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I found this with |find apps | grep '\.js$' | xargs -L 1 js -c|, not sure if it's intentional because of some test script black magic.

apps/calendar/test/integration/atoms/get_pos.js:6:0 SyntaxError: return not in function:
apps/calendar/test/integration/atoms/get_pos.js:6:0 return (function(element) {
apps/calendar/test/integration/atoms/get_pos.js:6:0 ^
apps/calendar/test/unit/view_test.js:17:0 SyntaxError: invalid label:
apps/calendar/test/unit/view_test.js:17:0     subject.selectors: {
apps/calendar/test/unit/view_test.js:17:0 ............^

I also fail to understand what the scripts involved do, so I couldn't fix it.

Comment 1

[James Lal [:lightsofapollo]]

Umm... I don't even have the slightest clue why its failing now... doing blame shows this error was introduced Oct 26th 2012... I have a patch coming very shortly...

Comment 2

[James Lal [:lightsofapollo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8692

Pointer to Github pull-request

Comment 3

[James Lal [:lightsofapollo]]

Comment on attachment 725838 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8692

OK, this fixes the view test... the integration test atom is read as a flat file then sent over the wire for marionette uses so that is fine... 

Again- maybe this breaks the built maybe it does not its a really old but bad syntax error that should never have been introduced.

Comment 4

[James Lal [:lightsofapollo]]

Landed here: https://github.com/mozilla-b2g/gaia/commit/0a45dccd0e8fb3a4c8c171794be83ffb1ff18439

It seems to have fixed the travis build... I somehow doubt this was the direct cause of the breakage (this code has been there with the syntax error some how for months).

Thanks for figuring this out Tim!

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 725838 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8692

r+ since Travis CI returns green (and you've merged the pull request anyway :P)

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Hey, the pull request doesn't fix 

apps/calendar/test/integration/atoms/get_pos.js

. Is that intentional? I'll keep this bug open.

Comment 7

[James Lal [:lightsofapollo]]

Hey Tim, yes this is intentional as I mentioned the atoms are read as flat files and sent over the wire via marionette and then are evaluated in a non-standard JS environment to work their magic.

Going to close this now.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to James Lal [:lightsofapollo] from comment #7)
> Hey Tim, yes this is intentional as I mentioned the atoms are read as flat
> files and sent over the wire via marionette and then are evaluated in a
> non-standard JS environment to work their magic.
> 
> Going to close this now.

Sorry about mis-reading your comment :-/ ... busy week.