Unnecessary scrollbar in Downloads Panel




Downloads Panel
5 years ago
3 years ago


(Reporter: Jim Jeffery not reading bug-mail 1/2/11, Unassigned)



Windows 7

Firefox Tracking Flags

(Not tracked)


With the landing of bug 848150 a scrollbar now appears in the Download Manager.
The scrollbar will appear with only one download. At most the New Download manager only shows 3 downloads, thus never a need to scrolling.


Tested with M-I builds:
20130317122332 c9d9b906b4e0 OK, no scrollbar
20130317124134 e69bc37414dd Bad scrollbar shown

Comment 1

5 years ago
Are you sure this is caused by that patch? If you read the patch, you'll see that I don't touch anything except about:home and Retina Mac-only theming of the search bar.
No, now I'm not sure...I hate these 100+ patch merges, makes testing a nightmare.

All I know is that the two builds I posted above, one is ok, and the next one, assuming I'm looking at M-I right (which might also be a possibility) is the one showing the scrollbar.  

However, I don't find cset anywhere in m-c builds, and your bug landed on m-c under a different cset..https://hg.mozilla.org/mozilla-central/rev/f4beba4909b0

I'll add regress window needed...to recheck the faulting patch.
Keywords: regressionwindow-wanted

Comment 3

5 years ago
The bug never actually landed on m-c. A larger patch landed on m-i and was backed out, and both the patch and backout landed on m-c simultaneously via a merge.

Comment 4

5 years ago
Later, a smaller patch did land and stick on m-i, and that will be merged to m-c soon.


5 years ago
Summary: Scrollbar in Download Panel after bug 848150 → Unnecessary scrollbar in Downloads Panel
ok, sorry for the confusion. Regression testing has become almost impossible for me and I don't have a clue how to use the regression tool even after reading instructions a 100 times.  

I'll leave it to someone else to find the regressor.
Need help with regression window.
20130317123236 53bafc73432d is good
20130317124732 09f72f45a0b7 is bad
Now after repeated downloads, testing different builds, etc.. I can no longer repo this problem I was getting, even after re-installed the 'suspected' bad cset, that I repeated the problem on at 3 different times, different installs. 

Now, I get it to break. 

I'll leave this open for now and test more in case it comes back, if not I'll close it in a day or so.
Should of said 'Now, I can't get it to break'

Testing this morning EDT I still cannot get it to show the scrollbar.  Something strange must of glitched on my end, even though I did find a good build, and going back to the 'suspect build', I could repeat the issue.

I always try to double/triple check a suspect build before pointing fingers, so it was very reproducible for a time, then all of sudden no longer doing it.


Apologies again to Frank for naming the wrong bug.
Last Resolved: 5 years ago
Resolution: --- → INVALID

Comment 9

5 years ago
(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #8)
> I always try to double/triple check a suspect build before pointing fingers,
> so it was very reproducible for a time, then all of sudden no longer doing
> it.

Yeah, we've had other odd glitches with our <panel> widgets that were not reliably reproducible (see bug 619532 for example, though that one is much worse) so this isn't especially surprising.
No longer blocks: 848150
Keywords: regressionwindow-wanted
You need to log in before you can comment on or make changes to this bug.