Status: NEW → ASSIGNED
Comment on attachment 726555 [details] [diff] [review] Patch Does that stretch well if the font size is increased? I don't thing vertical margins are need. -moz-box-align:center should be enough in theory. I won't have time to review that. Handing the review to Mihai.
Attachment #726555 - Flags: review?(paul) → review?(mihai.sucan)
I will change the alignment
Attachment #726555 - Flags: review?(mihai.sucan)
Created attachment 726616 [details] [diff] [review] Patch v2 Changed max-height and centred in OSX, Linux & Windows.
5 years ago
Attachment #726616 - Flags: review?(jwalker) → review+
(In reply to Victor Porof [:vp] from comment #6) > Created attachment 727186 [details] > not centered > > They don't seem to be centered on OS X... horizontally centered *
(In reply to Paul Rouget [:paul] from comment #7) Oh, this bug was about vertical alignment? Would it be a good idea to have horizontal alignment as well? My untrained eyes tells me that it could look better, but I may be wrong.
Victor: At first I misunderstood as well but it looked horribe when vertically aligned. https://hg.mozilla.org/integration/fx-team/rev/7a852243f456
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
s/vertically aligned/horizontally centered/
(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #9) > […] but it looked horribe when vertically aligned. How so?
I suspect that I am just not used to seeing tabs with the icon and text centered. Horizontally Centering has been moved out to bug 852975.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
You need to log in before you can comment on or make changes to this bug.