852049 - [Audio] The default value of Master Volume should be 1.0 if settings doesn't set a value.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Marco Chen [:mchen]]

History:
  1. We had removed the hack in shell.js which actively set master volume to 0.5 during boot up. That hack tried to limit volume when Gaia doesn't implement volume control yet.
  2. In setting.js, we tried to monitor audio.volume.master which will be set by Gaia and it's default value is 0.5 now.
  3. In Gaia side, now we control the volume by each audio channels (Android stream types) so we don't touch master volume directly.

Issue:
  According to the history, the master volume now is set to 0.5 not 1.0.

Comment 1

[Marco Chen [:mchen]]

Attachment: Patch v1

This patch set default value of master volume to 1.0 when settings DB doesn't have record of audio.master.volume.

Comment 2

[Marco Chen [:mchen]]

Issue: This bug limits the device's master volume to 0.5 only so the audio performance will be poor.

Risk: Low risk.
      Just ensure master volume to 1.0 if gaia doesn't set any value in settings DB.

Test: Build and Test the result successfully.

Comment 3

[Michael Vines [:m1] [:evilmachines]]

(tef-, the user can just increase the master volume right?)

Comment 4

[Marco Chen [:mchen]]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #3)
> (tef-, the user can just increase the master volume right?)

No, there is no way to adjust master volume from settings app.
Now we only control the volume on each stream type not master volume directly.

So ask tef again.

Comment 5

[Michael Vines [:m1] [:evilmachines]]

(got it, thanks)

Comment 6

[Michael Wu [:mwu]]

Comment on attachment 726010 [details] [diff] [review]
Patch v1

Seems ok if all the stream types have a sane default value..

Comment 7

[Marco Chen [:mchen]]

Attachment: Patch Checkin-Version

All green on try server.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96cd6c4b66fb

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/96cd6c4b66fb

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/282387708489
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/b2a16a3dd982

Comment 11

[sarsenyev]

Environmental  Variables:
Unagi Build ID: 20130403070201
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/512258bc00a3
Gaia: daea430624ec02f8d36a12d581fc4a3278c27cb7

Environmental  Variables:
Unagi Build ID: 20130403070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/d467369d1b0c
Gaia: 06e0e5ce42bdfb62bdbe38271de6b5b2d9e40e75

Verified it's fixed on V1.0.1 & V1.1.0 builds
The default value of Master Volume should be 1.0