852088 - Add drag caret to select text support

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Input, defect)

Description

[Jim Mathies [:jimm]]

todo:

add support for dragging to select text input.

See http://msdn.microsoft.com/en-us/library/windows/apps/hh465334.aspx

Comment 1

[Jim Mathies [:jimm]]

Attachment: drag selection (wip)

Comment 2

[Jim Mathies [:jimm]]

Attachment: caret drag selection v.1

This depends on the patch in bug 852087.

Comment 3

[Jim Mathies [:jimm]]

fyan - ping

Comment 4

[Jim Mathies [:jimm]]

Attachment: caret drag selection v.2

Updated per changes to the css in the parent bug.

Comment 5

[Frank Yan (:fryn)]

Comment on attachment 727629 [details] [diff] [review]
caret drag selection v.2

Review of attachment 727629 [details] [diff] [review]:
-----------------------------------------------------------------

Also read through bug 852087's patch to try to understand the context a bit more.

::: browser/metro/base/content/helperui/SelectionHelperUI.js
@@ +234,4 @@
>  
>    get startMark() {
>      if (this._startMark == null) {
> +      this._startMark = new Marker(this, "start", this._selectionMarkIds.pop(), 0, 0);

Using an array for these, instead of hard-coding them, doesn't seem to add any flexibility, because we still have to guarantee that the number of items in the array is greater than or equal to the number of mark getters that will call pop() on it. Are you anticipating more selection marks or mark getters in future pieces of the implementation?

Comment 6

[Jim Mathies [:jimm]]

(In reply to Frank Yan (:fryn) from comment #5)
> Comment on attachment 727629 [details] [diff] [review]
> caret drag selection v.2
> 
> Review of attachment 727629 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Also read through bug 852087's patch to try to understand the context a bit
> more.
> 
> ::: browser/metro/base/content/helperui/SelectionHelperUI.js
> @@ +234,4 @@
> >  
> >    get startMark() {
> >      if (this._startMark == null) {
> > +      this._startMark = new Marker(this, "start", this._selectionMarkIds.pop(), 0, 0);
> 
> Using an array for these, instead of hard-coding them, doesn't seem to add
> any flexibility, because we still have to guarantee that the number of items
> in the array is greater than or equal to the number of mark getters that
> will call pop() on it. Are you anticipating more selection marks or mark
> getters in future pieces of the implementation?

The array makes it easy to swap the caret image out for either start or end marker (depending on the drag direction) without having to worry about matching the opposite marker to an id.

so for example:

caret=mark3
drag left, swap
left=mark3
right=mark2

caret=mark3
drag right, swap
left=mark1
right=mark3

tap-hold select:
left=mark1
right=mark2

I just swap and push whatever spare id I have and let the getters take care of the rest.

Comment 7

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3025def19eb9

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3025def19eb9