852110 - Allow tools to build a concrete panel rather than only a promise of a panel

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Joe Walker [:jwalker]]

i.e. Allow:

    build: function(frame, target) {
      return new MyPanel(frame, target);
    }

In addition to

    build: function(frame, target) {
      var panel = new MyPanel(frame, target);
      return panel.open(window);
    }
    MyPanel.prototype.open = function() {
      return Promise.resolve(this);
    };

Comment 1

[Joe Walker [:jwalker]]

Attachment: v1

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 726140 [details] [diff] [review]
v1

Review of attachment 726140 [details] [diff] [review]:
-----------------------------------------------------------------

Simple enough.

Comment 3

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=3e7f38b6ccfc

Comment 4

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=f952eebd4cbd
https://hg.mozilla.org/integration/fx-team/rev/ed8fc1dfe8aa

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/ed8fc1dfe8aa