852118 - Speed up window.name

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jan de Mooij [:jandem]]

See bug 851109 for why this matters.

(Boris Zbarsky (:bz) from bug 851109 comment #3)
> That looks like update() calling FetchName calling
> js_NativeGet calling js::Shape::get calling nsIDOMWindow_GetName which then
> has to do all the unwrapping and call nsGlobalWindow::GetName, which is
> implemented in a moronic way (e.g. involves some extra malloc/free crap). 
> That part we can fix pretty easily, I think.  Worth filing a bug on that,
> blocking this one.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Stop window.name being malloc-happy.

This fixes the malloc-fest.  Further improvement would have to come from WebIDL bindings for Window, looks like.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 726249 [details] [diff] [review]
Stop window.name being malloc-happy.

uh, this old code from 1999-12-03 is...

nsWindowWatcher::OpenWindowInternal is tiny bit ugly.
Perhaps   
   if (windowNeedsName) {
     if (nameSpecified && !name.LowerCaseEqualsLiteral("_blank")) {
       newDocShellItem->SetName(name);
     } else {
       newDocShellItem->SetName(EmptyString());
     }   
   }

Comment 3

[Boris Zbarsky [:bzbarsky]]

Done.

Comment 4

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/b1af382d5750

Comment 5

[Boris Zbarsky [:bzbarsky]]

And https://hg.mozilla.org/integration/mozilla-inbound/rev/cfa733af8c86 to fix build bustage.

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b1af382d5750
https://hg.mozilla.org/mozilla-central/rev/cfa733af8c86

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

\o/