Closed Bug 852295 Opened 8 years ago Closed 8 years ago

LW Themes do not display in Permanent Private Browsing mode post Per-Window PB

Categories

(Toolkit :: General, defect)

defect
Not set
minor

Tracking

()

VERIFIED FIXED
mozilla22
Tracking Status
firefox20 --- affected
firefox21 --- verified
firefox22 --- verified
firefox23 --- verified

People

(Reporter: Cykesiopka, Assigned: Cykesiopka)

References

Details

Attachments

(2 files)

Pre Per-Window PB, Lightweight Themes would display even in permanent private browsing mode.

Post Per-Window PB, LW Themes only display in normal tabs, with permanent private browsing mode off.

IMO the previous behaviour is preferable, as there is no need to differentiate tabs when they are all private tabs.
And a patch that seems to work on Linux64. Not sure if this will break any tests however...
Attachment #726348 - Flags: feedback?(dao)
OS: Windows 7 → All
Hardware: x86_64 → All
Feedback ping?
Attachment #726348 - Flags: feedback?(dao) → review+
Assignee: nobody → cykesiopka
Blocks: 749394
Component: Themes → General
Keywords: checkin-needed
Duplicate of this bug: 854126
https://hg.mozilla.org/mozilla-central/rev/645f32d5e266
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
This is really in demand, see: https://support.mozilla.org/en-US/questions/955230.

Is there any way we could move this to an earlier milestone?
Comment on attachment 726348 [details] [diff] [review]
Proposed Patch v0

[Approval Request Comment]
Regression caused by (bug #): bug 749394
User impact if declined: Lightweight themes don't work in permanent private browsing mode
Testing completed (on m-c, etc.): on m-c during the 22 cycle
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none
Attachment #726348 - Flags: approval-mozilla-release?
Attachment #726348 - Flags: approval-mozilla-beta?
(In reply to Joshua Smith [:joshua-s] from comment #6)
> This is really in demand, see:
> https://support.mozilla.org/en-US/questions/955230.
> 
> Is there any way we could move this to an earlier milestone?

It seems like most complaints are about regular private browsing windows. This patch only fixes lightweight themes in *permanent* PB mode though.
Note that it is probably not a problem to enable lightweight themes for users on Windows, see duplicate bug 854126 comment 5. Maybe you could add a check for that case, too.
Duplicate of this bug: 859150
Comment on attachment 726348 [details] [diff] [review]
Proposed Patch v0

This isn't something we'd take in a dot release as a ridealong without testing on beta first.
Attachment #726348 - Flags: approval-mozilla-release? → approval-mozilla-release-
Attachment #726348 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Keywords: qawanted, verifyme
The verifyme is for FF21 specifically.
Duplicate of this bug: 857624
Duplicate of this bug: 853426
Duplicate of this bug: 860803
Duplicate of this bug: 861056
Duplicate of this bug: 861527
Verified as fixed on Windows 7 64bit, Ubuntu 12.10 32bit and Mac OSX 10.7.5 with Firefox 21 beta 3 (20130416200523).

LW themes are now also applied in permanent PB mode.
(In reply to Ioana Budnar [QA] from comment #18)
> Verified as fixed on Windows 7 64bit, Ubuntu 12.10 32bit and Mac OSX 10.7.5
> with Firefox 21 beta 3 (20130416200523).
> 
> LW themes are now also applied in permanent PB mode.

Thanks Ioana. Can you please verify this against the latest Aurora and Nightly builds when you get a chance?
QA Contact: ioana.budnar
Verified as fixed on the 04/17 Aurora and Nightly builds - Win7 64bit, Ubuntu 12.10 32bit and Mac OSX 10.8.3 64bit.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Attached patch PersonasSplinter Review
Duplicate of this bug: 861666
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #12)
> https://hg.mozilla.org/releases/mozilla-beta/rev/1422a858262d

Well, it seems that the fix has not reached FF 23.0 under Linux (Fedora 18): personas are still disabled in what you call "regular" private windows.
(In reply to bahamut00 from comment #23)
> (In reply to :Ehsan Akhgari (needinfo? me!) from comment #12)
> > https://hg.mozilla.org/releases/mozilla-beta/rev/1422a858262d
> 
> Well, it seems that the fix has not reached FF 23.0 under Linux (Fedora 18):
> personas are still disabled in what you call "regular" private windows.

This landed in Firefox 21, 22, and 23, and was verified to be working. If you are having an issue in the latest release please file a new bug and mark it as dependent on this bug.
Note that regular private windows were not intended to be affected by this change. Only file a new issue if lightweight themes are not showing up when Never Remember History is enabled.
You need to log in before you can comment on or make changes to this bug.