852321 - Use newer xulrunner to reduce download time on linux

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Bug 812105 reduced the size of the linux xulrunner SDKs by a large factor:

Platform       Current [1]      Latest [2]      Ratio
Linux 32         377MB             53MB          0.14       
Linux 64         378MB             62MB          0.16
Mac 64            52MB             70MB          1.35
Windows           31MB             36MB          1.16

Assuming there are no regressions in xpcshell Linux developers would get a big win from switching to a newer xulrunner.

[1] http://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/2012/09/2012-09-20-03-05-43-mozilla-central/
[2] http://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/2013/03/2013-03-18-03-09-47-mozilla-central/

Comment 1

[Chris AtLee [:catlee]]

Attachment: Use newer (smaller) xulrunner SDK

alternatively, we could pick something more recent like
http://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/2013/06/2013-06-11-03-11-40-mozilla-central/

Both seem to work fine in terms of creating the profile. I'm not sure what else to look for.

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 760932 [details] [diff] [review]
Use newer (smaller) xulrunner SDK

I was about to land a similar patch in bug 871542, but I wasn't sure everything would be alright on releng side.
It looks like you are confirming that we can change the xulrunner version without breaking TBPL or any release tools!

Thanks for the patch.

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 760932 [details] [diff] [review]
Use newer (smaller) xulrunner SDK

Checked in as https://github.com/mozilla-b2g/gaia/commit/2edbc123567161c4a379268a2714c39dadb3f847

Comment 4

[Ed Morley [:emorley]]

Burning:
https://tbpl.mozilla.org/php/getParsedLog.php?id=24150784&tree=Birch

Unable to back out as I don't have gaia commit access.

Comment 5

[Chris AtLee [:catlee]]

This is because the OSX SDKs no longer have bin/run-mozilla.sh. I guess we should be using xulrunner-sdk/bin/XUL.framework/Versions/Current/xulrunner instead?

Backed out.

Comment 6

[Chris AtLee [:catlee]]

If I try and set XPCSHELLSDK to /xulrunner-sdk/bin/XUL.framework/Versions/Current/xulrunner, then 'make profile' gives this error:

test -d profile || mkdir -p profile
run-js-command  applications-data
Error: unrecognized application.ini path.

Comment 7

[Jonathan Griffin (:jgriffin)]

On Mac, I could get it to work by changing both of these:

XULRUNNERSDK=./xulrunner-sdk/bin/XUL.framework/Versions/Current/run-mozilla.sh
XPCSHELLSDK=./xulrunner-sdk/bin/XUL.framework/Versions/Current/xpcshell

Comment 8

[Chris AtLee [:catlee]]

Attachment: Use newer (smaller) xulrunner SDK

Comment 9

[Alexandre Poirot [:ochameau]]

Comment on attachment 765406 [details] [diff] [review]
Use newer (smaller) xulrunner SDK

Review of attachment 765406 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 10

[Chris AtLee [:catlee]]

Comment on attachment 765406 [details] [diff] [review]
Use newer (smaller) xulrunner SDK

https://github.com/mozilla-b2g/gaia/commit/f7fffb5bf8caa8170f3a0d821ab1f7a195a244c0

Comment 11

[Julien Wajsberg [:julienw]]

Alex, Chris, do you think it's ok to uplift this ? The current situation triggers a download when we use make (eg: to push an ap pto the device) after changing the branch, which is extremely annoying. Especially that on v1-train it still downloads the bigger one :(

Comment 12

[Julien Wajsberg [:julienw]]

Well, I'll just do this after some sanity checks.

Comment 13

[Julien Wajsberg [:julienw]]

a=build
v1-train: 95d54226179251ce89a156c8e2cc588dbd8c631c

Comment 14

[Alexandre Poirot [:ochameau]]

(In reply to Julien Wajsberg [:julienw] from comment #11)
> Alex, Chris, do you think it's ok to uplift this ?

Yes, there is no particular reason why it wouldn't work on v1-train, nor need any particular tweaks.

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 95d54226179251ce89a156c8e2cc588dbd8c631c