Closed Bug 852360 Opened 9 years ago Closed 9 years ago

Kill some more unused stuff

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 22

People

(Reporter: Margaret, Assigned: Margaret)

Details

Attachments

(2 files)

We don't use the keyword.URL in region.properties.
http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#222
Attachment #726428 - Flags: review?(mark.finkle)
The strings we actually use are the ones in aboutAddons.dtd.
Attachment #726430 - Flags: review?(mark.finkle)
Attachment #726428 - Flags: review?(mark.finkle) → review+
Comment on attachment 726430 [details] [diff] [review]
Get rid of unused strings in aboutAddons.properties

These would be nice for a future context menu, but I guess we can always add them back.
Attachment #726430 - Flags: review?(mark.finkle) → review+
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 726430 [details] [diff] [review]
> Get rid of unused strings in aboutAddons.properties
> 
> These would be nice for a future context menu, but I guess we can always add
> them back.

Looks like we already use the .dtd versions for context menu items:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutAddons.xhtml#56
(In reply to :Margaret Leibovic from comment #3)

> Looks like we already use the .dtd versions for context menu items:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/
> aboutAddons.xhtml#56

Wow. I had forgot about that. I guess you should add context menu support for "Set as Default" in the search engine patch :)
https://hg.mozilla.org/mozilla-central/rev/4f2d3e8ce03f
https://hg.mozilla.org/mozilla-central/rev/d99bc9e32472
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 22
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.