852360 - Kill some more unused stuff

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

Attachment: Get rid of unused keyword.URL in region.properties

We don't use the keyword.URL in region.properties.
http://mxr.mozilla.org/mozilla-central/source/mobile/android/app/mobile.js#222

Comment 1

[:Margaret Leibovic]

Attachment: Get rid of unused strings in aboutAddons.properties

The strings we actually use are the ones in aboutAddons.dtd.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 726430 [details] [diff] [review]
Get rid of unused strings in aboutAddons.properties

These would be nice for a future context menu, but I guess we can always add them back.

Comment 3

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 726430 [details] [diff] [review]
> Get rid of unused strings in aboutAddons.properties
> 
> These would be nice for a future context menu, but I guess we can always add
> them back.

Looks like we already use the .dtd versions for context menu items:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutAddons.xhtml#56

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to :Margaret Leibovic from comment #3)

> Looks like we already use the .dtd versions for context menu items:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/
> aboutAddons.xhtml#56

Wow. I had forgot about that. I guess you should add context menu support for "Set as Default" in the search engine patch :)

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4f2d3e8ce03f
https://hg.mozilla.org/integration/mozilla-inbound/rev/d99bc9e32472

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4f2d3e8ce03f
https://hg.mozilla.org/mozilla-central/rev/d99bc9e32472