Use PIN keyboard to enter the passcode for lock screen and the SIM PIN

VERIFIED FIXED

Status

VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: xyuan, Unassigned)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(b2g18 affected, b2g18-v1.0.1 affected)

Details

Attachments

(4 attachments)

The PIN keyboard for the passcode field, was introduced by Bug 820268(https://bugzilla.mozilla.org/show_bug.cgi?id=820268).

The following passcode fields in the settings need to be changed to use the PIN keyboard:

 1. Phone lock passcode
  "Settings" -> "Phone Lock"
  Enable "Passcode lock"

 2. SIM PIN
  "Settings" -> "SIM Security"
  Enable "SIM PIN"

Note:
 Currently a number field whose x-inputmode attribute is "digits" will be recognized as a passcode field, which only accepts digits(0-9).
Created attachment 729242 [details]
Pull Request #8806 - Add x-inputmode="digits" for SIM/PUK/passcode input fields

Changes input fields for SIM/PUK/passcode from apps/settings and apps/system to add x-inputmode="digits".
Attachment #729242 - Flags: review?(rlu)
Attachment #729242 - Attachment mime type: text/plain → text/html
Comment on attachment 729242 [details]
Pull Request #8806 - Add x-inputmode="digits" for SIM/PUK/passcode input fields

r=me.

Thanks for your work.
Attachment #729242 - Flags: review?(rlu) → review+
(In reply to Rudy Lu [:rudyl] from comment #2)
> Comment on attachment 729242 [details]
> Pull Request #8806 - Add x-inputmode="digits" for SIM/PUK/passcode input
> fields
> 
> r=me.
> 
> Thanks for your work.

Thanks Rudy, updated the commit!
Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/95037dfcfa641fdd025d750e55c977b39de210da

Note:
This bug depends on Bug 820268, should not be uplifted without the following commit,
669a2d0308ef1175fdb4bb178d22e316ba9a08c6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
status-b2g18: --- → affected
status-b2g18-v1.0.1: --- → affected
Resolution: --- → FIXED
Hi, Rudy,

Thanks for your help.
As I verified this bug, the SIM PIN page works (Attachment-1_SIM_PIN_page.png) but the passcode lock page was broken(Attachment-2_Screen_Lock.png).
The bug injected at "Mozilla-central-unagi/2013-03-25-10-56-00"
Did you in charge of this page? Could you please trace the commit to know the problem or contact the owner?
Thanks!


Best Regards,
William
Created attachment 731813 [details]
SIM PIN page
Created attachment 731814 [details]
Passcode setting of screen lock page
Hi William,

The passcode lock page was broken before the patch of this bug landed. Thus it was not this bug that broke the passcode page.

I tested with the today's unagi build.

Bug 847552(https://bugzilla.mozilla.org/show_bug.cgi?id=847552) fixed the lock screen, but broke this patch :-(.
Sam Joch made some change to Bug 847552(https://bugzilla.mozilla.org/show_bug.cgi?id=847552) and the PIN keyboard should work now :-)
Verified this fix.

* Test build:(mozilla-central-unagi/2013/04/2013-04-05-10-34-53)
* Mercurial-Information:
  - Gecko revision="40a228f74389"
  - Gaia revision="fc2f77af69be"
* Git-Information:
  - Gecko revision="39839490f961009f7d0e259d85e6931cfd11263d"
  - Gaia revision="3f824d1dcb15c2c2f3e90483adc9f9d01f122477"

One more question, the key of lower left corner is empty.
If this is not requirement, please reopen this case.
Thanks!


Best Regards,
William
Status: RESOLVED → VERIFIED
Created attachment 734214 [details]
Digits Keyboard
Quote from "Bug 820268 - Comment #27"
-------------------------------------------------
"the lower left corner should be empty to keep the same layout as the numeric keyboard."
So, I don't have further concern regarding the UI layout. Thanks.


Best Regards,
William
You need to log in before you can comment on or make changes to this bug.