Make the DOM bindings example generator use the native type name.

RESOLVED FIXED

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jst, Assigned: jst)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Created attachment 726515 [details] [diff] [review]
Fix.

When using the example code generator it generates example code using the WebIDL interface name as the class name etc instead of using the native type name available to it. This makes it harder to cut n' paste the generated example code and use that as a starting point for writing the actual class.
Attachment #726515 - Flags: review?(bzbarsky)
(Assignee)

Updated

6 years ago
Assignee: nobody → jst
Comment on attachment 726515 [details] [diff] [review]
Fix.

>+              "nativeType": self.descriptor.nativeType }

Shouldn't that also use self.descriptor.nativeType.split('::')[-1]?

r=me with that
Attachment #726515 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 2

6 years ago
Created attachment 726774 [details] [diff] [review]
Updated fix.

This fixes the issue pointed out by bz, in all places for now (per irc discussion).
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/mozilla-central/rev/f4394e306dad
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.