Closed
Bug 852435
Opened 11 years ago
Closed 11 years ago
Make the DOM bindings example generator use the native type name.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: jst, Assigned: jst)
Details
Attachments
(2 files)
3.17 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
3.14 KB,
patch
|
Details | Diff | Splinter Review |
When using the example code generator it generates example code using the WebIDL interface name as the class name etc instead of using the native type name available to it. This makes it harder to cut n' paste the generated example code and use that as a starting point for writing the actual class.
Attachment #726515 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → jst
Comment 1•11 years ago
|
||
Comment on attachment 726515 [details] [diff] [review] Fix. >+ "nativeType": self.descriptor.nativeType } Shouldn't that also use self.descriptor.nativeType.split('::')[-1]? r=me with that
Attachment #726515 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 2•11 years ago
|
||
This fixes the issue pointed out by bz, in all places for now (per irc discussion).
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f4394e306dad
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•