Last Comment Bug 852461 - Remove growl support from comm-central
: Remove growl support from comm-central
Status: RESOLVED FIXED
[relnote = from TB 22]
:
Product: Thunderbird
Classification: Client Software
Component: OS Integration (show other bugs)
: Trunk
: x86 Mac OS X
: -- blocker (vote)
: Thunderbird 22.0
Assigned To: Florian Quèze [:florian] [:flo]
:
:
Mentors:
Depends on: 792793
Blocks: 782211
  Show dependency treegraph
 
Reported: 2013-03-19 02:12 PDT by Mark Banner (:standard8)
Modified: 2014-03-13 06:11 PDT (History)
8 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Description Mark Banner (:standard8) 2013-03-19 02:12:17 PDT
Bug 782211 has now landed, so we need to re-land this that was originally landed and then backed out.

+++ This bug was initially created as a clone of Bug #792793 +++

Bug 777409 removed growl support, and the comm-central tree is currently busted:
mailnews/base/src/nsMessengerOSXIntegration.mm:40:10: fatal error: 'nsINotificationsList.h' file not found
make[8]: *** [nsMessengerOSXIntegration.o] Error 1

The attached patch removes Growl specific code from mailnews, but keeps the call to nsIAlertsService, as that will use the new notification center on 10.8.
Comment 1 Mark Banner (:standard8) 2013-04-10 00:34:31 PDT
Obviously forgot to close this bug.

I'd re-landed the patch with a couple of extra changes for packaging files:

http://hg.mozilla.org/comm-central/rev/03cd0b12d3ef
http://hg.mozilla.org/comm-central/rev/6770dd37290f
Comment 2 Trane Francks 2013-07-05 03:43:02 PDT
Wow. What a monumental step backwards for those of us who are using Growl 1.2.2 on Snow Leopard. Yesterday, SeaMonkey 2.17.1 offered up notifications in line with every other application. As of 2.19, notifications are in a "Hey, LOOK AT ME" balloon".

Lovely. Not. Surely, there could have been another way.

Note You need to log in before you can comment on or make changes to this bug.