852531 - [New Tab Page] use promises to wait for a batch of operations to complete

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

We didn't have Promises when I built the new tab page so I came up with something similar in newtab/batch.js. I'd like to remove that code and just use Promises like:

Promise.all(promise1, promise2, promise3, ..., promiseN)

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: use promises to wait for a batch of operations to complete

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 726659 [details] [diff] [review]
use promises to wait for a batch of operations to complete

Review of attachment 726659 [details] [diff] [review]:
-----------------------------------------------------------------

I believe that you are going to be the first user of Promise.promised outside of addon-sdk, so I will be waiting for the try results :)

::: browser/base/content/newtab/transformations.js
@@ +180,5 @@
>          return;
>  
> +      let deferred = Promise.defer();
> +      batch.push(deferred.promise);
> +      let cb = function () deferred.resolve();

Remark: Actually, |deferred.resolve| is probably sufficient, but you are right to not rely on this.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://tbpl.mozilla.org/?tree=Try&rev=469757933782

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/f6e7195e87db

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/f6e7195e87db