852543 - B2G desktop builds failing during make check on m-c

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Hiding them (again) for now...

https://tbpl.mozilla.org/php/getParsedLog.php?id=20825258&tree=Firefox

XPCOM_DEBUG_BREAK=stack-and-abort /builds/slave/m-cen-osx64_g-0000000000000000/build/obj-firefox/dist/bin/run-mozilla.sh \
	  ../../dist/bin/TestRegistrationOrder "/builds/slave/m-cen-osx64_g-0000000000000000/build/xpcom/tests/regorder";
Running RegistrationOrder tests...
TEST-PASS | TestRegular
TEST-UNEXPECTED-FAIL | TestJar FAILED - cannot create extension service

TEST-PASS | RegTestOrderC
Finished running RegistrationOrder tests.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Adding some XPCOM peers to the party. This needs an owner, it's blocking B2G desktop builds from running on m-c and inbound.

Comment 2

[Benjamin Smedberg]

Is extension2.jar present and has the same/correct contents as in other builds?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

How would I tell? As best I can tell, those tests don't get packaged?
http://ftp.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/mozilla-central-win32_gecko/1363736354/

Comment 4

[Benjamin Smedberg]

extension2.jar is part of the source code (http://mxr.mozilla.org/mozilla-central/source/xpcom/tests/regorder/extension2.jar) I don't know how the B2G config differs from a regular config... perhaps the source is not at the normal expected location?

Comment 5

[Ryan VanderMeulen [:RyanVM]]

These are builds off m-c and inbound, so extension2.jar is in the same place.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

FWIW, we don't run make check on the b2g18 branches, so it's possible that this is broken there too and we just haven't known about it.

Comment 7

[Benjamin Smedberg]

Yeah, I didn't mean that the source location was different, but perhaps the location of the entire B2G source tree is different?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

AFAICT, these builds use the regular m-c source tree with Gaia cloned into $topsrcdir/gaia

Andreas, can you suggest someone who could help debug this?

Comment 9

[Ryan VanderMeulen [:RyanVM]]

So, checktests were disabled on purpose for the b2g18 branches in bug 821401 comment 20. Unfortunately, nobody ever followed up on fixing said tests so that we could enable them again. So here we are. Are we going to disable our way to victory again or can we look into what it takes to get this fixed and these tests enabled?

Comment 10

[[:fabrice] Fabrice Desré]

I can reproduce on a linux build also, I'll dig into that.

Comment 11

[[:fabrice] Fabrice Desré]

Attachment: patch

Kyle, the patch is in the binary jar, but is just applying there the same change as the one at:

https://hg.mozilla.org/mozilla-central/diff/5ce71981e005/xpcom/tests/regorder/extension/extComponent.js

Comment 12

[[:fabrice] Fabrice Desré]

http://hg.mozilla.org/integration/mozilla-inbound/rev/7f4e825f7c04

Comment 13

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/7f4e825f7c04