852550 - [email] naive drawer tray transition from bug 846901 with stationary folder list impacts fps; remove

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

In bug 846901, landing comment https://bugzilla.mozilla.org/show_bug.cgi?id=846901#c41 for pull request https://github.com/mozilla-b2g/gaia/pull/8709, we landed an attempted fix for bug 834665 to make the message list slide away to reveal a stationary folder list.

The easy solution for this (that I requested and reviewed! mea culpa!) regresses message list scrolling FPS per https://bugzilla.mozilla.org/show_bug.cgi?id=846901#c45 because it leaves the folder list in the viewport all the time.  A more complicated solution is required that avoids that problem without costing us our pre-prendering, but it's out of scope for bug 846901 and out of scope for this bug.  We should do it on bug 834665 and I will comment there.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/8713
https://github.com/mozilla-b2g/gaia/commit/dac742035dea44f4deab98ee333694e2c43c7159

Comment 2

[Julien Wajsberg [:julienw]]

Landed to v1-train as part of the Big Bug 851124 uplift.
(but not to v1.0.1).

Comment 3

[Julien Wajsberg [:julienw]]

Should this go to v1.0.1 as well ? if yes: why ?

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Julien Wajsberg [:julienw] from comment #3)
> Should this go to v1.0.1 as well ? if yes: why ?

Yes, this is part of the email FPS bug.  I spun it off to be its own new bug based on your request to try and create separate bugs for patches.  I made a little section of (gaia) patches to land related to FPS bugs in https://etherpad.mozilla.org/email-perf near the top (but forgot to tell you about it, I fear), specifically:

Changes to styling/transitions for e-mail FPS stuff (in this order):
https://bugzilla.mozilla.org/show_bug.cgi?id=846901#c30
https://bugzilla.mozilla.org/show_bug.cgi?id=846901#c41
https://bugzilla.mozilla.org/show_bug.cgi?id=852550#c1

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Julien Wajsberg [:julienw] from comment #2)
> Landed to v1-train as part of the Big Bug 851124 uplift.
> (but not to v1.0.1).

would this have been included in bug 851124 on v1.0.1?

Comment 6

[Julien Wajsberg [:julienw]]

John> nope, because I made the 2 uplifts at different time. This was kind of done on purpose, this may have been a bad idea, but I've taken great care to correctly flag the bugs.

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Julien Wajsberg [:julienw] from comment #6)
> John> nope, because I made the 2 uplifts at different time. This was kind of
> done on purpose, this may have been a bad idea, but I've taken great care to
> correctly flag the bugs.

Thank you for clarifying.  I'll uplift this.

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

there is nothing to commit here, those css rules aren't present in v1.0.1

Comment 9

[Julien Wajsberg [:julienw]]

They should.

That's probably because the Gaia part of bug 846901 wasn't actually uplifted... (yay)

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

v1.0.1: 577d13088ebdbd353d13910d3317e713a140415b
v1.0.1: b9cca452d985aa9da81b3bfb980446d2f4575a55 (Bug 846901)
v1.0.1: dd9293fa40b49537ce08e3e3f30b686470c07414 (Bug 846901)

Comment 11

[Darren]

There are test cases that cover this area.
https://moztrap.mozilla.org/manage/cases/?filter-id=1953

Comment 12

[Darren]

Cannot verify, we do not have hard numbers of what all should be improved.

Comment 13

[Darren]

Disregard previous comment

Performance seems to be running smooth on version 1.1.0 and 1.0.1.
Verified fixed on build:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/1d4c7fe3256e
Gaia: 2f64311e0f23b85c29b20be9502cbdeaee8342ae

Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/4931ec89ebbe
Gaia: 85fd164691bb852f1cfaf82405df4380629ced6e