852553 - Specify a standard destination dir for l10n clones

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Chris Cooper [:coop] (he/him)]

We don't specify a destination dir in the automation, so when we clone the l10n repos, we end up with clones in branch-specific locations. 

We are now using mozconfigs for l10n repacks. Because these destination dirs are referenced in these in-tree mozconfigs, we end up with branch-specific entries for --with-l10n-base that need to be modified during uplift on merge days.

We should start specifying a single destination dir for l10n clones that is invariant across branches.

Comment 1

[Alex Keybl [:akeybl]]

https://wiki.mozilla.org/Release_Management/Merge_Documentation#Until_bug_852553_is_fixed

Comment 2

[Chris Cooper [:coop] (he/him)]

Attachment: [buildbotcustom] Clone l10n repos to a standard 'l10n' dir regardless of branch

All l10n repos will now get cloned to a standard l10n/ dir under the base work dir. This removes the need to make branch-specific changes to the l10n-mozconfig files during uplift/merge days.

Patch for the mozilla-central mozconfigs is coming up. I should be able to uplift this patch trivially to aurora, beta, and release because it's NPOTB on beta and release.

Comment 3

[Chris Cooper [:coop] (he/him)]

Attachment: [mozilla-central] Set l10n base dir to l10n/ in mozconfigs

Comment 4

[Chris Cooper [:coop] (he/him)]

Attachment: [comm-central] Set l10n base dir to l10n/ in mozconfigs

Comment 5

[Chris Cooper [:coop] (he/him)]

re: testing - I've created successful repacks in staging for all platforms for both Firefox and Thunderbird on both central and aurora.

http://dev-master01.build.scl1.mozilla.com:8044/one_line_per_build

Comment 6

[Chris Cooper [:coop] (he/him)]

Comment on attachment 746551 [details] [diff] [review]
[buildbotcustom] Clone l10n repos to a standard 'l10n' dir regardless of branch

https://hg.mozilla.org/build/buildbotcustom/rev/c0fe7edf6ab7

Comment 7

[Chris Cooper [:coop] (he/him)]

Comment on attachment 746560 [details] [diff] [review]
[mozilla-central] Set l10n base dir to l10n/ in mozconfigs

https://hg.mozilla.org/mozilla-central/rev/8b3f78b002c2

Comment 8

[Chris Cooper [:coop] (he/him)]

Comment on attachment 746564 [details] [diff] [review]
[comm-central] Set l10n base dir to l10n/ in mozconfigs

https://hg.mozilla.org/comm-central/rev/f3ce31d62e7c

Comment 9

[Chris Cooper [:coop] (he/him)]

Landed with DONTBUILD and a=NPOTB on the following branches:

https://hg.mozilla.org/releases/mozilla-aurora/rev/1d3000010fdf
https://hg.mozilla.org/releases/mozilla-beta/rev/f935a7970137
https://hg.mozilla.org/releases/mozilla-release/rev/760eb84d4d7b

https://hg.mozilla.org/releases/comm-aurora/rev/576b6de8e072
https://hg.mozilla.org/releases/comm-beta/rev/ad1616a375e0

l10n builds don't get triggered by regular pushes, so it seemed a waste to do otherwise.

Comment 10

[Chris AtLee [:catlee]]

in production

Comment 11

[Chris Cooper [:coop] (he/him)]

(In reply to Alex Keybl [:akeybl] from comment #1)
> https://wiki.mozilla.org/Release_Management/
> Merge_Documentation#Until_bug_852553_is_fixed

I've removed this section from the Merge doc now.